-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8.1] [diracx] Get token and run integration tests #7143
Conversation
b764620
to
1dd163c
Compare
a645bdf
to
e7728bd
Compare
On this:
First of all, why would you need to change that? We said to remove the "Setup" concept, and several steps have been done in this direction (see notes for https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1). But, the changes up to now have been done only at the database level, and no changes in CS have been planned. "Setup" is everywhere in CS and no detailed plan have been drawn, and really the latest updates were in #5287. For this release we were not planning CS changes as the complexity of upgrading to v8.1 is already significant, but if there's a really good reason... |
# pylint: disable=import-error | ||
import os | ||
|
||
if os.getenv("DIRAC_ENABLE_DIRACX_JOB_MONITORING", "No").lower() in ("yes", "true"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is already applied in src/DIRAC/WorkloadManagementSystem/Client/JobMonitoringClient.py.
In general, I think that we can put all this code in src/DIRAC/WorkloadManagementSystem/Client/JobMonitoringClient.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because otherwise sphinx crashes. diracx
is not a dependency of DIRAC
so we have no other choice that hide all the diracx
code behind env variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you add diracx to
DIRAC/docs/diracdoctools/__init__.py
Line 8 in 4d534a3
DIRAC_DOC_MOCK_LIST = [ |
How does sphinx crash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try thanks !
When running the export script, it crashes without that, as there are no setup known
I think that saying that before upgrading to v8.1 it is necessary to copy all the |
That's a bit more than than. Something like
Should become
or even
all this supposing that |
We think we still need |
I am not sure I understand. What you suggests is the following ?
|
The above is just to say that what is below is a case:
|
I am now very confused. What I propose is that what is contained in the Setup or Default is promoted one level higher.
becomes
What is the use case not satisfied with this ? |
If the absence of "Defaults" is interpreted like today's "Defaults" then I think it's also fine. |
I think it even eases the migration because everything can just be copied one level up, prior to migrating to v8.1, so we don't even need to touch the code of v8.0 |
e7728bd
to
88c3cdd
Compare
7c976e1
to
973bb72
Compare
This should be transparent :-)
It starts integrating diracx by:
integration_tests
One thing could be disruptive though:(@fstagni ) The CSApi does not look anymore in
Default
or<Setup>
for the shifter.What's your plan for that migration ? Tell the people to copy everything under
/Default
to the root of theOperatons
section before upgrading ?BEGINRELEASENOTES
*CS
CHANGE: do not look for the shifter under the Default or section
*Test
NEW: allow integration tests to run against DiracX
*Core
NEW: get a token for a proxy
*WMS
NEW: call the diracx Job Monitoring endpoint
ENDRELEASENOTES