feat: adding bulk jdl submission and job policy checking #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mazenoux
force-pushed
the
feat-adding-bulk-jdl-submission
branch
from
7b02177
to
c073061
Compare
simon-mazenoux
changed the title
simon-mazenoux
changed the title
aldbr
reviewed
Sep 4, 2023
simon-mazenoux
force-pushed
the
feat-adding-bulk-jdl-submission
branch
3 times, most recently
from
9d75d48
to
cf82ae4
Compare
simon-mazenoux
force-pushed
the
feat-adding-bulk-jdl-submission
branch
from
cf82ae4
to
6e83553
Compare
|
This effectively depends from #67 (which in turn depends from DIRACGrid/DIRAC#7143). I convert to draft until the 2 above are sorted. |
chrisburr
reviewed
Sep 5, 2023
chrisburr
reviewed
Sep 5, 2023
Comment on lines
115
to
123
| class DiracxJobPolicy(JobPolicy): | ||
| def __init__(self, user_info: UserInfo, allInfo: bool = True): | ||
| self.userName = user_info.preferred_username | ||
| self.userGroup = user_info.dirac_group | ||
| self.userProperties = user_info.properties | ||
| self.jobDB = None | ||
| self.allInfo = allInfo | ||
| self._permissions: dict[str, bool] = {} | ||
| self._getUserJobPolicy() |
There was a problem hiding this comment.
Can we define this outside the method rather than creating a new class every time the API route is called?
There was a problem hiding this comment.
This was more a kind of proof of concept while waiting for a decision about attributing directly the properties during the token creation. In any case, this will need to be refactored because JobPolicy is also used in endpoinds such as kill, delete or reschedule
simon-mazenoux
force-pushed
the
feat-adding-bulk-jdl-submission
branch
from
6e83553
to
8d7b2ef
Compare
chrisburr
force-pushed
the
feat-adding-bulk-jdl-submission
branch
from
8d7b2ef
to
ebadbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bulk submission of jdls to the job submission endpoint, and implement job policy checking (solves Implement JobPolicy #23 )
(Tests need to be relaunched once DIRACGrid/DIRAC#7092 get merged)