Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Rails 6.0 to Rails 6.1 #374

Closed
wants to merge 35 commits into from
Closed

Upgrade from Rails 6.0 to Rails 6.1 #374

wants to merge 35 commits into from

Commits on May 12, 2021

  1. Bump ruby to 2.7.1

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9040cf0 View commit details
    Browse the repository at this point in the history

  2. Remove deprecated: quiet_assets

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    0feae76 View commit details
    Browse the repository at this point in the history

  3. Bump to rails 5.2.5

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    5aa4896 View commit details
    Browse the repository at this point in the history

  4. TEMP: Disable defra_ruby_email - no rails 5 version

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    714c222 View commit details
    Browse the repository at this point in the history

  5. Remove deprecated: raise_in_transactional_callbacks

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    204be6c View commit details
    Browse the repository at this point in the history

  6. Run: rails app update

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    dd36153 View commit details
    Browse the repository at this point in the history

  7. Update database schema

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    7db0fa1 View commit details
    Browse the repository at this point in the history

  8. Introduce: ApplicationRecord

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    c83da59 View commit details
    Browse the repository at this point in the history

  9. Introduce: ApplicationMailer

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    8fb4b5e View commit details
    Browse the repository at this point in the history

  10. Bump factory bot and updated rails helper path

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    5875abe View commit details
    Browse the repository at this point in the history

  11. Migrate factories (add curly braces)

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    22f0ad0 View commit details
    Browse the repository at this point in the history

  12. Revert to original bin/rails

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    b3d39a6 View commit details
    Browse the repository at this point in the history

  13. Workaround finite_machine

    @tobyprivett
    tobyprivett committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9d2fbbf View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Bump reform gem 

    - The previous version broke a lot of tests.
    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    f8336a7 View commit details
    Browse the repository at this point in the history

  2. Add gem "rails-controller-testing" 

    - Controller testing has been removed from Rails 5
    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    00e8abe View commit details
    Browse the repository at this point in the history

  3. Suspicious Factory workaround

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    6816880 View commit details
    Browse the repository at this point in the history

  4. Update controller specs with params key

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    8165e7f View commit details
    Browse the repository at this point in the history

  5. Prefer uppercase ENV 

    - Not sure why `env` would have worked with Rails 4, but it fails now
    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    84c5716 View commit details
    Browse the repository at this point in the history

  6. Append rails release version to the migrations

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    e0d165b View commit details
    Browse the repository at this point in the history

  7. Fix duplicate index declarations 

    - The migrations are failing because theses indexes already

- A change in Rails 5 was to create a `reference` field with an index
    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    63da3fd View commit details
    Browse the repository at this point in the history

  8. Bump to Rails 6.1

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    9257e6b View commit details
    Browse the repository at this point in the history

  9. Down to Rails 6.0 as defra_ruby_email is pinned at 6.0

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    b90a016 View commit details
    Browse the repository at this point in the history

  10. Prefer gems in the gemspec

    @tobyprivett
    tobyprivett committed May 13, 2021
    Configuration menu
    Copy the full SHA
    23d1126 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Bump defra-ruby-alert and rename method: blocklist

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    c1e5a37 View commit details
    Browse the repository at this point in the history

  2. Rails 6 prefers rails over rake

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    26bf52a View commit details
    Browse the repository at this point in the history

  3. Fix rubocop name warning

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    850ded8 View commit details
    Browse the repository at this point in the history

  4. Further gem bumps

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    f081ee3 View commit details
    Browse the repository at this point in the history

  5. Faker prefers keyword arguments

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    601c1fd View commit details
    Browse the repository at this point in the history

  6. Prefer update over update_attributes

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2beba0b View commit details
    Browse the repository at this point in the history

  7. Module#parent_name has been renamed to module_parent_name

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    d53000c View commit details
    Browse the repository at this point in the history

  8. These params don't need to be a hash

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2b68124 View commit details
    Browse the repository at this point in the history

  9. Bump activerecord-session_store

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    d87b41f View commit details
    Browse the repository at this point in the history

  10. NOT conditions will no longer behave as NOR in Rails 6.1

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    bb7afa4 View commit details
    Browse the repository at this point in the history

  11. Bump nokogiri and defra_ruby_area

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    4a94034 View commit details
    Browse the repository at this point in the history

  12. Fixnum has become Integer

    @tobyprivett
    tobyprivett committed May 14, 2021
    Configuration menu
    Copy the full SHA
    f5d5d82 View commit details
    Browse the repository at this point in the history