Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Rails 6.0 to Rails 6.1 #374

Closed
wants to merge 35 commits into from
Closed

Upgrade from Rails 6.0 to Rails 6.1 #374

wants to merge 35 commits into from

Conversation

tobyprivett
Copy link
Contributor

@tobyprivett tobyprivett commented May 14, 2021 •
edited
Loading

Blockers:

@tobyprivett
Bump ruby to 2.7.1
9040cf0
@tobyprivett
Remove deprecated: quiet_assets
0feae76
@tobyprivett
Bump to rails 5.2.5
5aa4896
@tobyprivett
TEMP: Disable defra_ruby_email - no rails 5 version
714c222
@tobyprivett
Remove deprecated: raise_in_transactional_callbacks
204be6c
@tobyprivett
Run: rails app update
dd36153
@tobyprivett
Update database schema
7db0fa1
@tobyprivett
Introduce: ApplicationRecord
c83da59
@tobyprivett
Introduce: ApplicationMailer
8fb4b5e
@tobyprivett
Bump factory bot and updated rails helper path
5875abe
@tobyprivett
Migrate factories (add curly braces)
22f0ad0
@tobyprivett
Revert to original bin/rails
b3d39a6
@tobyprivett
Workaround finite_machine
9d2fbbf
@tobyprivett
Bump reform gem
f8336a7 
- The previous version broke a lot of tests.
@tobyprivett
Add gem "rails-controller-testing"
00e8abe 
- Controller testing has been removed from Rails 5
@tobyprivett
Suspicious Factory workaround
6816880
@tobyprivett
Update controller specs with params key
8165e7f
@tobyprivett
Prefer uppercase ENV
84c5716 
- Not sure why `env` would have worked with Rails 4, but it fails now
@tobyprivett
Append rails release version to the migrations
e0d165b
@tobyprivett
Fix duplicate index declarations
63da3fd 
- The migrations are failing because theses indexes already

- A change in Rails 5 was to create a `reference` field with an index
@tobyprivett
Bump to Rails 6.1
9257e6b
@tobyprivett
Down to Rails 6.0 as defra_ruby_email is pinned at 6.0
b90a016
@tobyprivett
Prefer gems in the gemspec
23d1126
@tobyprivett
Bump defra-ruby-alert and rename method: blocklist
c1e5a37
@tobyprivett
Rails 6 prefers rails over rake
26bf52a
@tobyprivett
Fix rubocop name warning
850ded8
@tobyprivett
Further gem bumps
f081ee3
@tobyprivett
Faker prefers keyword arguments
601c1fd
@tobyprivett
Prefer update over update_attributes
2beba0b
@tobyprivett
Module#parent_name has been renamed to module_parent_name
d53000c
@tobyprivett tobyprivett changed the title Upgrade to Rails 6 and Ruby 2.7 Upgrade to Rails 6.1 May 18, 2021
@tobyprivett tobyprivett changed the title Upgrade to Rails 6.1 Upgrade from Rails 6.0 to Rails 6.1 May 18, 2021
@tobyprivett
Copy link
Contributor Author

Closing in favour of this PR: #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobyprivett