Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup turborepo, with injected dependency syncing #145

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 25, 2023

Supersedes: #44
Inspired by: CrowdStrike/ember-headless-form#52
Presently blocked on: pnpm/pnpm#6088
Unblocking PR to pnpm: pnpm/pnpm#6135
I'm working on that pr to add pnpm sync to the pnpm CLI. -- once merged/released, The hope is that this PR is able to go green.

Once this is proven to work, I'm going to add an ember-apply template for easily applying these changes to any pnpm monorepo (and then add documentation to the v2 addon blueprint for folks that may be interested in adding turbo -- though, there is an argument for using turbo by default, as once pnpm sync exists, we can automate away all the issues with injected dependencies transparently from users)

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2023

⚠️ No Changeset found

Latest commit: d7a79f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vitch
Copy link
Contributor

vitch commented Apr 26, 2023

What's the status of this?

My understanding is that without it we are not able to make changes in the ember-headless-table package and see those changes reflected in the docs-app and test-app?

I was able to remove the "dependenciesMeta": object from docs-app/package.json and get automatic reloads there as a workaround but removing it from test-app/package.json resulted in all the tests failing because "decorator is not a function"...

@NullVoxPopuli
Copy link
Contributor Author

What's the status of this?

this particular implementation is blocked on my own adding a feature to pnpm (pnpm sync), which requires some spelunking on my part (see linked issues).

Simon and Tony have a strategy in ember-toucan-core and ember-headless-form for fixing this problem via in an in-monorepo extra package.

@vitch vitch mentioned this pull request May 2, 2023
@vitch
Copy link
Contributor

vitch commented May 16, 2023

FYI CrowdStrike/ember-headless-form#140 improves the DX around the extra package approach - I think the same would be interesting here on top of #168

@NullVoxPopuli
Copy link
Contributor Author

Reminder to myself to revisit: https://twitter.com/nullvoxpopuli/status/1662431120149848064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants