Fix test app invocation #159
Conversation
|
Preview URLsGH Env: preview |
|
|
||
| When you make changes to the files in this repo you must create a [changeset](https://github.com/changesets/changesets): | ||
|
|
||
| * `pnpm changeset` |
There was a problem hiding this comment.
Ymmv/imo, ofc, but this is only true if a change is consumer facing, and warrants a changelog entry / consumers of the library need to know what happened
There was a problem hiding this comment.
I've updated the docs and removed the changeset :)
vitch
force-pushed
the
fix-test-app-invocation
branch
from
2a77ff7
to
e2be0b4
Compare
| @@ -27,6 +27,20 @@ | |||
| * `cd docs-app` | |||
| * `pnpm start` – starts the test app and tests are available at `/tests` | |||
|
|
|||
| ## Running everything together | |||
|
|
|||
| * `pnpm start` - starts the addon, the tests, the docs app and the docs API | |||
There was a problem hiding this comment.
This only starts the docs-app for me?
There was a problem hiding this comment.
On this branch? The changes in package.json are what were necessary to make it also build the tests.
I think the docs API is running for you but it's not an Ember app so it doesn't log the same stuff...
There was a problem hiding this comment.
Ahhh gotcha.
Okay so after doing the following, test-app and docs-app work for me locally:
cd ember-toucan-core
pnpm build
pnpm link .
cd ../docs-app
pnpm link ember-headless-table # temporary for local development, not to be checked in
cd ../test-app
pnpm link ember-headless-table # temporary for local development, not to be checked in
cd ../ #switch to route
pnpm start
There was a problem hiding this comment.
Yeah - the change in this PR make it so that things build but they don't make it so that changes in ember-headless-table are consumed in the docs or test app...
I think #145 is the proper solution to that - all the linking is super hacky.
Sidenote - instead of linking I think you can delete the dependenciesMeta part of package.json and run pnpm install --force once. Again it shouldn't be committed (because the dev dependencies of ember-headless-table can leak into the consuming apps) but it might be a more ergonomic hack for now. FWIW this worked great on the docs app when I tried but the tests app didn't like it and I didn't dig in further...
Previously it was trying to launch the `ember-headless-table` package for the tests but in fact it needs to launch the `test-app`.
To cover a) running everything and b) changelogs
vitch
force-pushed
the
fix-test-app-invocation
branch
from
e2be0b4
to
45dc4d7
Compare
I was about to look into #152 and I noticed that running
pnpm startat the root of the monorepo didn't build the test app,This PR fixes that and updates some docs.