Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename expenses.md to README.md #1171

Closed
wants to merge 11 commits into from

Conversation

ContentBrewmaster
Copy link
Contributor

@ContentBrewmaster ContentBrewmaster commented Jun 5, 2023

Changing file name to README


📚 Documentation preview 📚: https://civicactions-handbook--1171.org.readthedocs.build/en/1171/

@ContentBrewmaster ContentBrewmaster marked this pull request as ready for review June 5, 2023 14:40
@ContentBrewmaster ContentBrewmaster requested review from a team as code owners June 5, 2023 14:40
@grugnog
Copy link
Member

grugnog commented Jun 5, 2023

@ContentBrewmaster it's not clear to me that expenses makes sense as the top level page for this section. It seems like we would want something more general here?

@ContentBrewmaster
Copy link
Contributor Author

ContentBrewmaster commented Jun 5, 2023

@grugnog typically I would agree but there is a complete overhaul of benefits and policies in the works with Marc, Elizabeth, and Kimberlin. I'm hoping to remove the dependency of that work (which could take a month) on this change so we can install the new editing tool.

@ContentBrewmaster ContentBrewmaster enabled auto-merge (squash) June 5, 2023 17:46
Fixing navigation so expenses stays in view when other pages in this section selected.
@ContentBrewmaster
Copy link
Contributor Author

I don't understand how to fix the redirects file. @dmundra can you help?

@dmundra
Copy link
Collaborator

dmundra commented Jun 7, 2023

I don't understand how to fix the redirects file. @dmundra can you help?

Yes, it is fixed. The redirects are being added to the end of the file and other pull requests are adding to that same file in the same location which is causing the conflict. So we have to move changes in the PR to come after those new changes.

auto-merge was automatically disabled August 9, 2023 20:08

Pull request was closed

@ContentBrewmaster ContentBrewmaster deleted the ContentBrewmaster-company-policies branch August 9, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants