[WIP] brainstorming for /vote fast + prototype [WILL NOT BE UN-WIP-ED]

cron/poll_pull_requests.py

@@ -3,7 +3,7 @@
 import os
 import sys
 from os.path import join, abspath, dirname
-from lib.db.models import MeritocracyMentioned
+from lib.db.models import MeritocracyMentioned, Issue
 
 import settings
 import github_api as gh
@@ -73,6 +73,16 @@ def poll_pull_requests(api):
             # the PR is mitigated or the threshold is not reached ?
             if variance >= threshold or not is_approved:
                 voting_window = gh.voting.get_extended_voting_window(api, settings.URN)
+
+                # read the db to see if this PR is expedited by /vote fast...
+                try:
+                    issue = Issue.get(issue_id=pr["id"])
+                    if issue.expedited: # expedite
+                        voting_window /= 2
+
+                except Issue.DoesNotExist:
+                    pass # not expedited
+
                 if (settings.IN_PRODUCTION and vote_total >= threshold / 2 and
                         seconds_since_updated > base_voting_window and not meritocracy_satisfied):
                     # check if we need to mention the meritocracy

cron/poll_read_issue_comments.py

@@ -21,7 +21,7 @@
 
 # If no subcommands, map cmd: None
 COMMAND_LIST = {
-        "/vote": ("close", "reopen")
+        "/vote": ("close", "reopen", "fast")
     }
 
 __log = logging.getLogger("read_issue_comments")
@@ -38,9 +38,12 @@ def get_seconds_remaining(api, comment_id):
 def insert_or_update(api, cmd_obj):
     # Find the comment, or create it if it doesn't exit
     comment_id = cmd_obj["global_comment_id"]
-    issue, _ = Issue.get_or_create(issue_id=cmd_obj["issue_id"])
     user, _ = User.get_or_create(login=cmd_obj["user"]["login"],
                                  user_id=cmd_obj["user"]["id"])
+    issue, _ = Issue.get_or_create(issue_id=cmd_obj["issue_id"],
+                                   user=user, # TODO: I don't think this is the right one
+                                   created_at=cmd_obj["created_at"], # TODO: I don't think this is the right one
+                                   expedited=False)
 
     comment, _ = Comment.get_or_create(comment_id=comment_id,
                                        user=user, text=cmd_obj["comment_text"],
@@ -131,7 +134,10 @@ def get_command_votes(api, urn, comment_id):
     return votes
 
 
-def handle_vote_command(api, command, issue_id, comment_id, votes):
+def handle_vote_command(api, command, cmdmeta, votes):
+    issue_id = cmdmeta.issue.issue_id
+    comment_id = cmdmeta.comment.comment_id
+
     orig_command = command[:]
     # Check for correct command syntax, ie, subcommands
     log_warning = False
@@ -143,6 +149,33 @@ def handle_vote_command(api, command, issue_id, comment_id, votes):
         elif sub_command == "reopen":
             gh.issues.open_issue(api, settings.URN, issue_id)
             gh.comments.leave_issue_reopened_comment(api, settings.URN, issue_id)
+        elif sub_command == "fast":
+            comment_updated_at = cmdmeta.comment.updated_at
+            comment_created_at = cmdmeta.comment.created_at
+            comment_poster = cmdmeta.comment.user
+            issue_poster = cmdmeta.issue.user
+            issue_created_at = cmdmeta.issue.created_at
+
+            # The post should not have been updated
+            if updated_at != created_at:
+                return
+
+            # The comment poster must be in the meritocracy
+            meritocracy = {}
+            with open('server/meritocracy.json', 'r') as mfp:
+                fs = fp.read()
+                if fs:
+                    meritocracy = json.loads(fs)
+
+            if comment_poster not in meritocracy:
+                return
+
+            # The comment must posted within 5 min of the issue
+            if (arrow.get(comment_created) - arrow.get(issue_created_at)).total_seconds() > 5*60:
+                return
+
+            # Leave a note on the issue that it is expedited
+            Issue.update(expedited=True).where(Issue.issue_id == cmdmeta.issue.issue_id).execute()
         else:
             # Implement other commands
             pass
@@ -174,7 +207,7 @@ def handle_comment(api, cmd):
                                                                        comment=comment_text))
 
         if command == "/vote":
-            handle_vote_command(api, parsed_comment, issue_id, comment_id, votes)
+            handle_vote_command(api, parsed_comment, cmd, votes)
 
         update_command_ran(api, comment_id, "Command Ran")
 

github_api/voting.py

@@ -9,7 +9,6 @@
 
 import settings
 
-
 def get_votes(api, urn, pr, meritocracy):
     """ return a mapping of username => -1 or 1 for the votes on the current
     state of a pr.  we consider comments and reactions, but only from users who

lib/db/models.py

@@ -28,6 +28,9 @@ class Comment(BaseModel):
 
 class Issue(BaseModel):
     issue_id = pw.IntegerField(primary_key=True)
+    created_at = pw.DateField()
+    user = pw.ForeignKeyField(User, related_name='poster')
+    expedited = pw.BooleanField()
 
 
 class ActiveIssueCommands(BaseModel):