[WIP] brainstorming for /vote fast + prototype [WILL NOT BE UN-WIP-ED] #493

mark-i-m · 2017-06-03T04:34:30Z

Start work for /vote fast

My proposal is here in #401 .

~~This PR is not intended to implement any feature, but to implement some needed functions/methods/utilities that might be needed, and to just plan in general.~~

~~The actual feature will probably wait for @rudehn's work on database stuff.~~

Thoughts and comments appreciated...

EDIT: I added some code to implement this feature now that @rudehn's work is in... I will probably not un-WIP this. Rather, when it looks good, I will create a new PR, so as not to take advantage of those who already voted.

mark-i-m · 2017-06-03T04:36:09Z

Useful links:

https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue

https://developer.github.com/v3/pulls/#get-a-single-pull-request

anythingbot · 2017-06-03T14:28:41Z

Downvoting because the code doesn't do anything (aside from create space for some potential future code) and the PR isn't clear enough.

If you make the code do something and the PR says what the code does, then maybe I'll upvote.

some needed functions/methods/utilities that might be needed

I don't even know how the feature is supposed to work, so how a I going to know what functions might be needed? I'd like to evaluate your judgement and design decisions, but I don't know how the feature you want to build works...and you didn't update the code with the feature...so this is all a bit of a mystery.

mdcfe · 2017-06-03T15:23:05Z

@anythingbot The proposal for the feature is... wait, he already linked it:

My proposal is here in #401.

This is marked WIP - it's clearly not finished yet, and mark even said that this is only the beginning of the work for it.

rudehn · 2017-06-03T18:00:11Z

@mark-i-m you will need to change the COMMANDS_LIST variable and add the fast subcommand to it. Command syntax is checked against whatever is in the commands_list.

Ajedi32 · 2017-06-05T17:12:51Z

Wait, does chaosbot avoid automatically merging [WIP] PRs? I didn't realize that was something it did.

rudehn · 2017-06-05T17:13:37Z

Yep. If it has WIP it will not be merged

rudehn · 2017-06-05T17:32:00Z

DB is in, this can be finished

mark-i-m · 2017-06-08T01:15:47Z

@rudehn Can you confirm that I am not messing up the database stuff?

rudehn · 2017-06-08T01:25:25Z

Walk me through what you are trying to do. What does /vote fast do?

mark-i-m · 2017-06-08T01:37:45Z

When a new PR is created, a meritocrat has 5 min to post a /vote fast
If the comment is edited it is ignored
If (1) and (2) hold, then a marker is placed on the PR in the db... Specifically, the Issue table is augmented with an "expedited" column.
During the PR polling, if the PR (which is an issue w.r.t. github api IIUC) has an "expedited" flag set in its record in the db, then the voting window is halfed.

PlasmaPower · 2017-06-08T01:54:44Z

cron/poll_pull_requests.py

+                try:
+                    issue = Issue.get(issue_id=pr["id"])
+                    if issue.expedited: # expedite
+                        voting_window /= 2


This code needs to be moved out of the if statement for the extended voting window. Currently this just halves the extended voting window.

PlasmaPower

There are also a bunch of flake8 warnings, and some of them are critical (e.g. you forgot to import json in cron/poll_read_issue_comments.py).

PlasmaPower · 2017-06-08T01:56:41Z

cron/poll_read_issue_comments.py

+            with open('server/meritocracy.json', 'r') as mfp:
+                fs = fp.read()
+                if fs:
+                    meritocracy = json.loads(fs)


This seems a bit flaky. How about defining a function get_meritocracy with the current code for generating the meritocracy?

server/meritocracy.json is temporary - it shouldn't ideally be read from because it's only there to fill the gap before the database is ready and we can use that instead.

@md678685 What should I do instead? Would it be ok to define get_meritocracy as @PlasmaPower said and simply re-implement it when the db is ready?

I don't think it would need re-implemented when the DB is ready. Sure, the DB could be used, but there's no point in that since this code and the main loop (PRs) run in the same process (so they share the same memoization cache).

PlasmaPower · 2017-06-08T01:57:22Z

cron/poll_pull_requests.py

+                        voting_window /= 2
+
+                except Issue.DoesNotExist:
+                    pass # not expedited


Also, add an except: log.exception("Failed to get expedited status")

@PlasmaPower This is not necessarily a failure, though... It just means nobody has posted /vote fast on this PR. In fact, we expect that to be the common case, so these would flood the logs.

I'm not sure you understand. I'm saying keep the current error handler, but add another general one in case a different exception happens.

Ah, my bad... fixed

PlasmaPower · 2017-06-08T02:01:52Z

@mark-i-m Don't you also want to require additional meritocracy reviews? Also, should the author of the PR be able to /vote fast it?

dbpokorny · 2017-06-08T20:06:53Z

@mark-i-m this can be done with a mysql database, but this isn't necessary; it can also be done with a github label. That way the bot can check for labels on the PR to see if the "expedited" label is present. If so, the bot cuts the voting window in half.

PlasmaPower · 2017-06-08T20:15:58Z

@dbpokorny That's a great idea! I'm not sure it'll be necessary though, since we do have a DB and an implementation using it.

mark-i-m · 2017-06-09T00:43:44Z

Adding the label does sound like a good way of visually differentiating fast PRs on the PR list, though...

dbpokorny · 2017-06-09T00:50:24Z

@PlasmaPower My whole take on expedited PRs is that it effectively turns the chaosbot into a bicameral legislature; so I think either method is fine. Part of the issue here is that using a mysql database doesn't reveal the status of the PR using the github web interface; you'll still have to add the github label in order to signal the status of the PR to github users. So, the thinking goes, if github is going to remember the status, then there isn't any need (on this project) for additional mysql configuration.

I'm under the impression that the only data this database would store is expedited status for each PR. Is that correct?

PlasmaPower · 2017-06-09T00:53:04Z

@dbpokorny That is a good point in favor of a label. I guess we could add a label, but pull the info from the DB. And yes, I think you're correct about the DB model.

dbpokorny · 2017-06-09T01:06:00Z

@PlasmaPower pull what info from the database? I don't understand what that is

mark-i-m · 2017-06-09T01:33:58Z

cron/poll_read_issue_comments.py

+
+    # db insert
+    issue, _ = Issue.get_or_create(issue_id=issue_id,
+                                   number=number,


Does anyone know what the difference between these is? Can I drop one of them?

I would recommend using the defaults param here for anything not in the primary key. We were having issues using this syntax before

mark-i-m · 2017-06-09T01:41:13Z

Ok, I think I have code representing roughly what has been discussed above. I really doubt it runs in its current state. Mostly, I would appreciate feedback from reviews about what should be changed. After that, I will fix up broken things and submit a new PR. Think of this PR as pseudocode for the real one...

mark-i-m · 2017-06-09T01:41:37Z

Will be back tomorrow 💤

mark-i-m · 2017-06-09T01:43:56Z

Also, should the author of the PR be able to /vote fast it?

Sorry, I didn't see this earlier. I don't think so. If it is something that should be /vote fasted, then the mertiocracy should be aware of it. Otherwise, I think it will just get abused.

PlasmaPower · 2017-06-09T02:16:04Z

First issues to fix should be Travis. There are some undefined names and such.

rudehn · 2017-06-09T02:45:49Z

cron/poll_read_issue_comments.py

+
+    # db insert
+    issue, _ = Issue.get_or_create(issue_id=issue_id,
+                                   number=number,


I would recommend using the defaults param here for anything not in the primary key. We were having issues using this syntax before

rudehn · 2017-06-09T02:46:30Z

cron/poll_read_issue_comments.py

    user, _ = User.get_or_create(user_id=cmd_obj["user"]["id"],
                                 defaults={"login": cmd_obj["user"]["login"]})
-
+    issue = insert_or_update_issue(api, cmd_obj["issue_id"], cmd_obj["number"])


where are you getting cmd_obj["number"] from? I don't think this exists

I think it ought to be just returned from github, right: https://developer.github.com/v3/issues/#list-issues-for-a-repository?

Am I missing something?

Yep. Read comments.py / get_all_issue_comments. It doesn't return the entire structure. You might need to change that

Ah, good catch. Fixed

rudehn · 2017-06-09T02:47:19Z

cron/poll_read_issue_comments.py

+                return
+
+            # The post should not have been updated
+            if updated_at != created_at:


maybe leave some kind of response indicating why the command didn't run? Makes debugging easier

Hmm... yes, I see your point... but would this be prone to inducing spam?

rudehn · 2017-06-09T02:48:06Z

lib/db/models.py

@@ -28,6 +28,11 @@ class Comment(BaseModel):

 class Issue(BaseModel):
    issue_id = pw.IntegerField(primary_key=True)
+    number = pw.IntegerField()


what is this number?

The PR number as oppose to PR id? The thing is when github returns a PR, it returns a value called "id" which is not the PR number we see on github, and it returns a "number" which is the number we see on github. TBH, I am really confused about which to use where. I think we want to use issue/PR numbers, rather than ids, but the db models appear to use the ids. Any help/auditing on this point would be appreciated.

The ids are used when making api calls. I think that's why we store them

Hmm... interesting. Most of the API I saw for issues and PRs take the issue/PR number, though?

rudehn · 2017-06-09T02:50:07Z

cron/poll_read_issue_comments.py

@@ -145,6 +178,48 @@ def handle_vote_command(api, command, issue_id, comment_id, votes):
            gh.issues.close_issue(api, settings.URN, issue_id)
        elif sub_command == "reopen":
            gh.issues.open_issue(api, settings.URN, issue_id)
+        elif sub_command == "fast":


maybe pull this out into it's own function?

PlasmaPower · 2017-06-10T19:12:34Z

cron/poll_read_issue_comments.py

@@ -135,7 +157,63 @@ def get_command_votes(api, urn, comment_id):
    return votes


-def handle_vote_command(api, command, issue_id, comment_id, votes):
+def get_meritocracy():
+    # FIXME: update when this is done by the db


I'm not sure the meritocracy will ever be stored in the DB. Instead, put this code in the function.

PlasmaPower · 2017-06-10T19:31:19Z

This code should also be changed to use the get_meritocracy function (maybe move it into a more general file).

mark-i-m · 2018-08-30T19:08:48Z

I would like to close this PR to clean up my dashboard. Does anyone have objections?

mdcfe · 2018-08-30T21:10:19Z

As with the other issue, no objection here.

brainstorming for /vote fast

dd4c8bf

mark-i-m mentioned this pull request Jun 3, 2017

Get bug fixes in quicker #401

Open

lint ... eh, why not

fd3f872

updated COMMAND_LIST

48e9fd1

mark-i-m mentioned this pull request Jun 3, 2017

Shorten voting window for every meritocracy approval #408

Closed

mark-i-m added 3 commits June 6, 2017 00:25

Merge branch 'master' into fast_fix

a7b0e27

Added some (probably wrong) code

accf700

Merge branch 'master' of https://github.com/chaosbot/Chaos into fast_fix

6cde8da

PlasmaPower reviewed Jun 8, 2017

View reviewed changes

PlasmaPower suggested changes Jun 8, 2017

View reviewed changes

Don't just halve the extended window

eef11e0

mark-i-m added 2 commits June 8, 2017 20:53

pull out get_meritocracy

8b3c316

Require 5 +1's from the meritocracy to expedite

965ac7d

mark-i-m added 3 commits June 8, 2017 21:07

Mention meritocracy on expedite

9872097

oops... ping when nominated

95659ee

add label to expedited prs

20c7c08

mark-i-m changed the title ~~[WIP] brainstorming for /vote fast~~ [WIP] brainstorming for /vote fast + prototype [WILL NOT BE UN-WIP-ED] Jun 9, 2017

corrected issue insertion

c655b91

mark-i-m commented Jun 9, 2017

View reviewed changes

get the pr for the PR number

f5c39db

rudehn reviewed Jun 9, 2017

View reviewed changes

mark-i-m added 5 commits June 10, 2017 10:55

use defaults for issues

e520f3f

pull out /vote fast logic to its own fn

740a780

fixed some typos/bugs

1c65501

lint

c7933a5

get issue number from comment

d48f779

PlasmaPower reviewed Jun 10, 2017

View reviewed changes

meritocracy code

d147db4

mark-i-m closed this Aug 31, 2018

[WIP] brainstorming for /vote fast + prototype [WILL NOT BE UN-WIP-ED] #493

[WIP] brainstorming for /vote fast + prototype [WILL NOT BE UN-WIP-ED] #493

Conversation

mark-i-m commented Jun 3, 2017 • edited Loading

mark-i-m commented Jun 3, 2017

anythingbot commented Jun 3, 2017

mdcfe commented Jun 3, 2017

rudehn commented Jun 3, 2017

Ajedi32 commented Jun 5, 2017

rudehn commented Jun 5, 2017

rudehn commented Jun 5, 2017

mark-i-m commented Jun 8, 2017

rudehn commented Jun 8, 2017

mark-i-m commented Jun 8, 2017

Choose a reason for hiding this comment

PlasmaPower left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PlasmaPower Jun 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PlasmaPower commented Jun 8, 2017

dbpokorny commented Jun 8, 2017 • edited Loading

PlasmaPower commented Jun 8, 2017

mark-i-m commented Jun 9, 2017

dbpokorny commented Jun 9, 2017

PlasmaPower commented Jun 9, 2017 • edited Loading

dbpokorny commented Jun 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-i-m commented Jun 9, 2017

mark-i-m commented Jun 9, 2017

mark-i-m commented Jun 9, 2017

PlasmaPower commented Jun 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PlasmaPower commented Jun 10, 2017

mark-i-m commented Aug 30, 2018

mdcfe commented Aug 30, 2018

mark-i-m commented Jun 3, 2017 •

edited

Loading

PlasmaPower Jun 9, 2017 •

edited

Loading

dbpokorny commented Jun 8, 2017 •

edited

Loading

PlasmaPower commented Jun 9, 2017 •

edited

Loading