Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kern.features.cheri_purecap_kernel #2229

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

Add kern.features.cheri_purecap_kernel #2229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sys/cheri/cheri_sysctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
#include <cheri/cheri.h>

#ifdef __CHERI_PURE_CAPABILITY__
FEATURE(cheriabi_kernel, "CheriABI kernel");
FEATURE(cheri_purecap_kernel, "pure-capability kernel");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FEATURE(cheri_purecap_kernel, "pure-capability kernel");
FEATURE(cheri_purecap_kernel, "CHERI pure-capability kernel");

#ifdef __CHERI_SUBOBJECT_BOUNDS__
FEATURE(subobject_bounds, "CheriABI kernel with sub-object bounds");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FEATURE(subobject_bounds, "CheriABI kernel with sub-object bounds");
FEATURE(subobject_bounds, "CHERI pure-capability kernel with sub-object bounds");

I think Konrad's suggestion of renaming this to include "cheri" might also be useful.

#endif

Check warning on line 43 in sys/cheri/cheri_sysctl.c

View workflow job for this annotation

GitHub Actions / Style Checker 

Missing Signed-off-by: line
#ifdef __ARM_MORELLO_PURECAP_BENCHMARK_ABI
FEATURE(benchmark_abi_kernel, "Morello benchmark ABI kernel");
#endif
Expand Down
Loading