Add kern.features.cheri_purecap_kernel #2229
Conversation
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capaiblity kernel (not CheriABI which refers to userspace).
|
Nothing in tree uses the old feature flag so I think it's safe to drop. Could keep it for a release instead, but we'd then need to remember to remove it. |
There was a problem hiding this comment.
It might be worth renaming other features to match kernel config options and indicate that they refer to CHERI/Morello:
kern.features.subobject_boundstokern.features.cheri_subobject_boundskern.features.cheri_revoketokern.features.cheri_caprevokekern.features.benchmark_abi_kerneltokern.features.morello_benchmarkabi_kernel.
That would be useful when listing features with sysctl kern.features | grep 'cheri\|morello'.
| @@ -37,7 +37,7 @@ | |||
| #include <cheri/cheri.h> | |||
|
|
|||
| #ifdef __CHERI_PURE_CAPABILITY__ | |||
| FEATURE(cheriabi_kernel, "CheriABI kernel"); | |||
| FEATURE(cheri_purecap_kernel, "pure-capability kernel"); | |||
There was a problem hiding this comment.
| FEATURE(cheri_purecap_kernel, "pure-capability kernel"); | |
| FEATURE(cheri_purecap_kernel, "CHERI pure-capability kernel"); |
| @@ -37,7 +37,7 @@ | |||
| #include <cheri/cheri.h> | |||
|
|
|||
| #ifdef __CHERI_PURE_CAPABILITY__ | |||
| FEATURE(cheriabi_kernel, "CheriABI kernel"); | |||
| FEATURE(cheri_purecap_kernel, "pure-capability kernel"); | |||
| #ifdef __CHERI_SUBOBJECT_BOUNDS__ | |||
| FEATURE(subobject_bounds, "CheriABI kernel with sub-object bounds"); | |||
There was a problem hiding this comment.
| FEATURE(subobject_bounds, "CheriABI kernel with sub-object bounds"); | |
| FEATURE(subobject_bounds, "CHERI pure-capability kernel with sub-object bounds"); |
I think Konrad's suggestion of renaming this to include "cheri" might also be useful.
This doesn't say purecap in it. Given we have cheri_purecap_kernel, probably morello_purecap_benchmark_kernel is the best thing (with a possible _abi in there too if you want). |
This one is queried by bits of userspace, so an upgraded kernel would break them. |
This should say kernel in it too for the feature name? |
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capaiblity kernel (not CheriABI which refers to userspace).