feat: Add Package definition on hugr-core
#1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 85.79% 85.75% -0.04%
==========================================
Files 135 136 +1
Lines 24687 24746 +59
Branches 21623 21682 +59
==========================================
+ Hits 21180 21221 +41
- Misses 2405 2423 +18
Partials 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ss2165
reviewed
Oct 16, 2024
Comment on lines
+127
to
+131
| btree_map::Entry::Occupied(mut prev) => { | ||
| if prev.get().version() < extension.version() { | ||
| *prev.get_mut() = extension.clone(); | ||
| } | ||
| Ok(prev.into_mut()) |
|
I added some Note that we are not enforcing that packages must only contain module-rooted HUGRs. |
This was referenced Oct 17, 2024
Closed
Merged
This was referenced Oct 17, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Followup to #1587. Ensures that rust `Package`s only contain module-rooted hugrs. Returns errors at construction times if the condition is not met. This required fixing `hugr-cli`, as it should be able to load both packages and arbitrary hugrs. Added `Package::from_hugr{,s}` methods that try to wrap the hugrs if possible. We'll need these for tket2. Packages are not on the spec yet, their description should include this restriction. See #1388. This PR does only modify the (unpublished) API introduced in #1587, so I'm not marking it as breaking.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Replaces the breaking changes introduced in #1587 with non-breaking deprecations. We should be able to remove these on the next breaking release.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
## 🤖 New release * `hugr`: 0.13.1 -> 0.13.2 (✓ API compatible changes) * `hugr-core`: 0.13.1 -> 0.13.2 (✓ API compatible changes) * `hugr-model`: 0.13.1 -> 0.13.2 (✓ API compatible changes) * `hugr-passes`: 0.13.1 -> 0.13.2 (✓ API compatible changes) * `hugr-cli`: 0.13.1 -> 0.13.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.13.2](hugr-v0.13.1...hugr-v0.13.2) - 2024-10-22 ### Bug Fixes - Allocate ports on root nodes ([#1585](#1585)) ### New Features - Render function names in `mermaid`/`dot` ([#1583](#1583)) - Add filter_edge_kind to PortIterator ([#1593](#1593)) - make errors more readable with Display impls ([#1597](#1597)) - Ensure packages always have modules at the root ([#1589](#1589)) - Add `Package` definition on `hugr-core` ([#1587](#1587)) </blockquote> ## `hugr-core` <blockquote> ## [0.13.2](hugr-core-v0.13.1...hugr-core-v0.13.2) - 2024-10-22 ### Bug Fixes - Allocate ports on root nodes ([#1585](#1585)) ### New Features - Add `Package` definition on `hugr-core` ([#1587](#1587)) - Render function names in `mermaid`/`dot` ([#1583](#1583)) - Add filter_edge_kind to PortIterator ([#1593](#1593)) - make errors more readable with Display impls ([#1597](#1597)) - Ensure packages always have modules at the root ([#1589](#1589)) </blockquote> ## `hugr-model` <blockquote> ## [0.13.2](hugr-model-v0.13.1...hugr-model-v0.13.2) - 2024-10-22 ### New Features - make errors more readable with Display impls ([#1597](#1597)) </blockquote> ## `hugr-passes` <blockquote> ## [0.13.2](hugr-passes-v0.13.1...hugr-passes-v0.13.2) - 2024-10-22 ### New Features - make errors more readable with Display impls ([#1597](#1597)) </blockquote> ## `hugr-cli` <blockquote> ## [0.13.2](hugr-cli-v0.13.1...hugr-cli-v0.13.2) - 2024-10-22 ### New Features - Add `Package` definition on `hugr-core` ([#1587](#1587)) - Ensure packages always have modules at the root ([#1589](#1589)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the definition of packages out of
hugr-cli. (We leave a re-export there to avoid breaking the API, it should be removed on the next breaking release).Adds some helper functions to load and validate the package.
Closes #1530
drive-by: Replace
hugr-coredependency onhugr-clibyhugr. There's no need to access the internals there.