Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unbreak release #1591

Merged
merged 2 commits into from
Oct 21, 2024
Merged

chore: Unbreak release #1591

merged 2 commits into from
Oct 21, 2024

Conversation

aborgna-q
Copy link
Collaborator

Replaces the breaking changes introduced in #1587 with non-breaking deprecations.
We should be able to remove these on the next breaking release.

@aborgna-q aborgna-q requested a review from ss2165 October 17, 2024 16:28
@aborgna-q aborgna-q requested a review from a team as a code owner October 17, 2024 16:28
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

Base automatically changed from ab/package-checks to main October 21, 2024 11:02
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.64%. Comparing base (d349eee) to head (65acbb2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/package.rs 22.72% 17 Missing ⚠️
hugr-cli/src/lib.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   85.72%   85.64%   -0.08%     
==========================================
  Files         136      136              
  Lines       24891    24918      +27     
  Branches    21827    21854      +27     
==========================================
+ Hits        21338    21342       +4     
- Misses       2445     2468      +23     
  Partials     1108     1108              
Flag Coverage Δ
python 92.68% <ø> (ø)
rust 84.66% <18.51%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q
Copy link
Collaborator Author

I had to add some temporary manual Display/Error impls due to derive_more#419.

@aborgna-q aborgna-q added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 45c3106 Oct 21, 2024
21 of 22 checks passed
@aborgna-q aborgna-q deleted the ab/unbreak-changes branch October 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants