Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example: voltage clamp #408

Merged

Conversation

AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Aug 13, 2024

Description

New example: voltage clamp with data from channelpedia and jupyter notebook

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (2cddd26) to head (1c765be).
Report is 31 commits behind head on master.

Files Patch % Lines
efel/pyfeatures/pyfeatures.py 84.37% 10 Missing ⚠️
tests/test_pyfeatures.py 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   91.73%   92.22%   +0.48%     
==========================================
  Files          36       39       +3     
  Lines        6278     7509    +1231     
  Branches     2033     2297     +264     
==========================================
+ Hits         5759     6925    +1166     
- Misses        266      300      +34     
- Partials      253      284      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier marked this pull request as draft August 23, 2024 11:57
@AurelienJaquier AurelienJaquier marked this pull request as ready for review August 26, 2024 08:01
docs/source/eFeatures.rst Outdated Show resolved Hide resolved
docs/source/eFeatures.rst Outdated Show resolved Hide resolved
docs/source/eFeatures.rst Outdated Show resolved Hide resolved
@AurelienJaquier
Copy link
Collaborator Author

I also added fitting curves to the plot of the example as requested by @darshanmandge in latest commit

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AurelienJaquier !

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AurelienJaquier !

@AurelienJaquier AurelienJaquier merged commit e9bcd51 into BlueBrain:master Aug 28, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the voltage-clamp-example branch August 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants