Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoot refactor, Drive & joint movment blocking, overshoot turn fix #180

Merged
merged 22 commits into from
Apr 28, 2021
Merged

Scoot refactor, Drive & joint movment blocking, overshoot turn fix #180

merged 22 commits into from
Apr 28, 2021

Conversation

Carter90
Copy link
Contributor

@Carter90 Carter90 commented Apr 12, 2021 •
edited
Loading

  • refactored a bunch of names to be consistent with PEP8
  • Update missed python2.7 -> python3 changes
  • added some function locks for diving & joint movement, callbacks & getters
  • driving and Turning should now be blocking calls until completion
  • turn overshot issue should be gone
  • lowered drive speed to reduce slipping
  • added translate(strafing) capability to API, move request messaging and to driver

Known bug with translating goal distance opened #190

scoot.translate(-3,-3)
scoot.turn(math.pi/2)
scoot.translate(-3,-3)

Solves #184 #183 #184

@Carter90 Carter90 linked an issue Apr 12, 2021 that may be closed by this pull request
Restore locking/Blocking methods in scoot #177
Closed
@Carter90 Carter90 linked an issue Apr 13, 2021 that may be closed by this pull request
Combined Linear/Angular Movement #183
Closed
@Carter90 Carter90 linked an issue Apr 19, 2021 that may be closed by this pull request
Turn overshoots ~pi/4 #184
Closed
@Carter90 Carter90 changed the title Scoot refactor DRAFT Scoot refactor, Drive & joint movment blocking, overshoot turn fix Apr 26, 2021
@gmfricke gmfricke removed the request for review from johncarl81 April 26, 2021 19:42
@gmfricke gmfricke requested review from gmfricke and johncarl81 and removed request for gmfricke and johncarl81 April 26, 2021 19:42
@Carter90 Carter90 linked an issue Apr 27, 2021 that may be closed by this pull request
Python3 threading Semaphore changes #163
Closed
@gmfricke gmfricke merged commit f0ccb02 into master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmfricke gmfricke gmfricke approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
3 participants
@Carter90 @gmfricke @abbypribis