Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serviceKeyVaultLocation bicep parameter #736

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-infrastructure/configurations/svc-cluster.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ param clusterServicePostgresPrivate = false

param serviceKeyVaultName = 'aro-hcp-dev-svc-kv'
param serviceKeyVaultResourceGroup = 'global'
param serviceKeyVaultLocation = 'westus3'
param serviceKeyVaultSoftDelete = true
param serviceKeyVaultPrivate = false

Expand Down
5 changes: 4 additions & 1 deletion dev-infrastructure/templates/svc-cluster.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ param serviceKeyVaultName string
@description('The name of the resourcegroup for the service keyvault')
param serviceKeyVaultResourceGroup string = resourceGroup().name

@description('The location of the resourcegroup for the service keyvault')
param serviceKeyVaultLocation string = resourceGroup().location

@description('Soft delete setting for service keyvault')
param serviceKeyVaultSoftDelete bool = true

Expand Down Expand Up @@ -242,7 +245,7 @@ module serviceKeyVault '../modules/keyvault/keyvault.bicep' = {
name: 'service-keyvault'
scope: resourceGroup(serviceKeyVaultResourceGroup)
params: {
location: location
location: serviceKeyVaultLocation
keyVaultName: serviceKeyVaultName
private: serviceKeyVaultPrivate
enableSoftDelete: serviceKeyVaultSoftDelete
Expand Down
Loading