add serviceKeyVaultLocation bicep parameter #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-schndr
requested review from
bennerv,
geoberle,
janboll,
jmelis,
jonathan34c,
mjlshen,
niontive,
nwnt,
UlrichSchlueter,
weinong and
whober0521
as code owners
geoberle
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add a parameter to set the location of the shared serviceKeyvault. This fixes resourceGroup/location conflicts as bicep tries to deploy the keyvault to the wrong location when deploying aks clusters to locations other than
westus3and using the shared serviceKeyvault.For personal development environments the location will point to westus3, for all other environments the location of the deployment resource group will be used.
Jira:
Link to demo recording:
Special notes for your reviewer