Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses lowercase path segment names #58

Merged
merged 2 commits into from
Apr 16, 2024
Merged

uses lowercase path segment names #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2093f
uses lowercase path segment names in accordance with our lowercase mi…
s-amann Apr 16, 2024
f885b80
Clarify comment for using lowercase path segments
s-amann Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ const (
ContextKeyCorrelationData
ContextKeySystemData

// Wildcard path segment names for request multiplexing
// Wildcard path segment names for request multiplexing, must be lowercase as we lowercase the request URL pattern when registering handlers
PageSegmentLocation = "location"
PathSegmentSubscriptionID = "subscriptionId"
PathSegmentResourceGroupName = "resourceGroupName"
PathSegmentResourceName = "resourceName"
PathSegmentActionName = "actionName"
PathSegmentSubscriptionID = "subscriptionid"
PathSegmentResourceGroupName = "resourcegroupname"
PathSegmentResourceName = "resourcename"
PathSegmentActionName = "actionname"
)
2 changes: 1 addition & 1 deletion frontend/frontend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ func (f *Frontend) ArmSubscriptionAction(writer http.ResponseWriter, request *ht
return
}

subId := request.PathValue(strings.ToLower(PathSegmentSubscriptionID))
subId := request.PathValue(PathSegmentSubscriptionID)
f.cache.SetSubscription(subId, &subscription)

resp, err := json.Marshal(subscription)
Expand Down
Loading