Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses lowercase path segment names #58

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

s-amann
Copy link
Contributor

@s-amann s-amann commented Apr 16, 2024

What this PR does

Before this PR:
PathSegments would need to be lowercased before being used in request.PathValue

After this PR:
Now they don't

bennerv
bennerv previously approved these changes Apr 16, 2024
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a comment clarification, but LGTM otherwise.

frontend/const.go Outdated Show resolved Hide resolved
@mbarnes mbarnes merged commit 7500875 into Azure:main Apr 16, 2024
4 checks passed
@s-amann s-amann deleted the lower-case-mux-keys branch April 16, 2024 19:10
AldoFusterTurpin pushed a commit to AldoFusterTurpin/ARO-HCP that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants