Update phpcompatibility to develop version to get sniffs for PHP 8 #9697
+60
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the latest stable one only covers up to PHP 7.4.
alopezari
added
the
focus: devops
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 370-gh-Automattic/woocommerce-payments-meta
Changes proposed in this Pull Request
We use a PHPCS extension - PHPCompatibility - to check the compatibility of our plugin with multiple PHP versions.
We were using the latest stable version 9.3.5. However, this version was released in 2019 and it doesn't cover rules for PHP 8.
This PR adds the following changes:
dev-developversion of PHPCompatibility to include sniffs for all PHP 8 versions, including new sniffs for PHP 8.4 - yet to be released.dev-developversion was tagged as fake9.3.5to keep compatibility with other dependencies.phpcs.xml.distconfig file are 7.3-7.4. This is because our code is fully compatible with these versions but there are some warnings and errors for PHP 8, which would break our pipelines sincephpcs.xml.distrules are required for PRs to be merged.This way, we will be able to spot potential incompatibilities with PHP 8.4 before this PHP version is out.
Note
A follow up task will be created to fix the PHP 8 warnings and errors.
Testing instructions
npm run lint:php -- --no-cacheand check that no errors appear../vendor/bin/phpcs --standard=phpcs-compat.xml.dist $(git ls-files | grep .php$)and check that multiple errors and warnings appear, most of all of them related to PHP 8 incompatibilities (you can see in the log the PHP version each error/warning is related to).PR Compatibility, that should fail due to PHP 8 errors and warnings.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge