-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2024: Loading and Error screens #2369
Changes from all commits
22f6347
fa70f9e
2fd944d
5ea5230
c892943
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,28 +98,30 @@ struct StoriesView: View { | |
|
||
VStack(spacing: 15) { | ||
let progress = syncProgressModel.progress | ||
CircularProgressView(value: progress, stroke: Color.white, strokeWidth: 6) | ||
CircularProgressView(value: progress, stroke: model.indicatorColor, strokeWidth: 6) | ||
.frame(width: 40, height: 40) | ||
Text(L10n.loading) | ||
.foregroundColor(.white) | ||
.foregroundColor(model.indicatorColor) | ||
.font(style: .body) | ||
} | ||
|
||
storySwitcher | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bjtitus I'm not sure if this needs to be here. Forcing the loading view or error to be in the body causes a crash when tapping. the start method called causes an Inf value calculating the current progress. WDYT? |
||
header | ||
} | ||
.background(model.primaryBackgroundColor) | ||
} | ||
|
||
var failed: some View { | ||
ZStack { | ||
Spacer() | ||
|
||
Text(L10n.eoyStoriesFailed) | ||
.foregroundColor(.white) | ||
.foregroundColor(model.indicatorColor) | ||
|
||
storySwitcher | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bjtitus Same here. WDYT? |
||
header | ||
} | ||
.background(model.primaryBackgroundColor) | ||
.onAppear { | ||
Analytics.track(.endOfYearStoriesFailedToLoad) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjtitus I found this text unlocalized. I changed it but let me know if I need to revert it.