Playback 2024: Loading and Error screens #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielebogo
commented
Oct 31, 2024
| @@ -42,7 +42,7 @@ struct Top5Podcasts2024Story: ShareableStory { | |||
| .disabled(!isSmallScreen) // Disable scrolling on larger where we shouldn't be clipping. | |||
| .frame(height: geometry.size.height * 0.65) | |||
|
|
|||
| Text("And you were big on these shows too!") | |||
| Text(L10n.eoyStoryTopPodcastsTitle) | |||
There was a problem hiding this comment.
@bjtitus I found this text unlocalized. I changed it but let me know if I need to revert it.
danielebogo
commented
Oct 31, 2024
| .frame(width: 40, height: 40) | ||
| Text(L10n.loading) | ||
| .foregroundColor(.white) | ||
| .foregroundColor(.black) | ||
| .font(style: .body) | ||
| } | ||
|
|
||
| storySwitcher |
There was a problem hiding this comment.
@bjtitus I'm not sure if this needs to be here. Forcing the loading view or error to be in the body causes a crash when tapping. the start method called causes an Inf value calculating the current progress. WDYT?
danielebogo
commented
Oct 31, 2024
| } | ||
|
|
||
| var failed: some View { | ||
| ZStack { | ||
| Spacer() | ||
|
|
||
| Text(L10n.eoyStoriesFailed) | ||
| .foregroundColor(.white) | ||
| .foregroundColor(.black) | ||
|
|
||
| storySwitcher |
There was a problem hiding this comment.
@bjtitus Same here. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify styles to our previous loading and error screens.
Localize one text in
Top5Podcasts2024StoryTo test
StoriesView-> body to force the loading and error stateChecklist
CHANGELOG.mdif necessary.