Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar id collision between user id and guest-author post type #960

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

katag9k
Copy link
Contributor

@katag9k katag9k commented Jul 28, 2023

Description

Fixes filtering issues when a user has the same id as a guest-author post id.

Steps to Test

Ensure a guest author shares the same id (post_id) with a current WordPress user id.

  • Login as the WordPress user - the WordPress admin bar will display the proper user avatar instead of the wrong guest author avatar
  • Go to /wp-admin/profile.php the correct avatar will be displayed under Profile Picture
  • Go to /wp-admin/users.php correct avatars will be displayed for both WordPress users and guest authors
  • Create a new article and add both guest authors and WordPress users to the Authors meta box, proper avatars will be displayed

Addresses: #907

@katag9k katag9k requested a review from GaryJones July 28, 2023 20:44
@katag9k katag9k changed the title Fix avatar id collision between user id and guest-user post type Fix avatar id collision between user id and guest-author post type Jul 28, 2023
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed - admin bar, user list, guest author list all have the correct images. Thanks!

@GaryJones GaryJones added this to the 3.5.12 milestone Jul 29, 2023
@GaryJones GaryJones merged commit 759f992 into master Jul 29, 2023
10 checks passed
@GaryJones GaryJones deleted the fix-avatar-id-collision branch July 29, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants