Fix ajax_suggest user and guest author id collision

[katag9k]

Description

Related to #960. When a WordPress user shares the same id as a guest-author post id, the CAP meta box will display the wrong avatar after searching for user or guest author.

Steps to Test

Ensure a guest author shares the same id (post_id) with a current WordPress user id.

• Login as the WordPress user
• Create a new article and search for both the guest author and the WordPress user that have colliding ids in the Authors Metabox. Correct avatars will be displayed

[GaryJones]

I'm unable to replicate this issue, and I can't see where user_type is a recognised array key for the extra args of get_avatar_url().

@katag9k Can you shed some more light here please? Screenshots, quick video, please.

[katag9k]

@GaryJones user_type distinction was added in the previous PR, it lives here:

Co-Authors-Plus/co-authors-plus.php

Lines 1858 to 1860 in 45dbb83

	if ( isset( $args['user_type'] ) && 'wp-user' === $args['user_type'] ) {
	return $args;
	}

When adding authors to a post but before saving the post, the incorrect avatar will show up for users that have the same ID as the guest author post type id.

[GaryJones]

@katag9k I'm still not seeing it.

In my example, "gary" is a regular user, user_id = 7. I am logged into that account. It's my face showing as it picks up the gravatar from the user email address. It happens to also exist as a mapped guest author. ✅

The "A Guest Author" account is a guest author account, not linked to a regular user. The post_id = 7. The image matches the Set Avatar feature of editing the guest profile. ✅

When I remove the guest author avatar, then it correctly falls back to the Gravatar default image:

If I remove the guest author mapping for "gary" (so it is only a regular user), then the behaviour is the same.

I'm going to need more hand-holding to replicate this please.

[GaryJones]

Since I was logged in as the duplicitous user, the new post I was creating already had me assigned as the author (see gary in the screenshots above).

When I added a random author (Minnie), so I could then remove gary, and then start to add gary and get the Ajax result, I could see the wrong URL being delivered.

Before - the San Francisco URL is for "A Guest Author" (post_id=7):

After applying this PR - the Gravatar URL is the correct one for gary (user_id = 7).

[GaryJones]

✅