-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExternalAHRS: support variances in backends #28405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugobliterator
approved these changes
Oct 16, 2024
tridge
force-pushed
the
pr-external-AHRS-variances
branch
from
October 16, 2024 19:22
1b6ac8c
to
8cdf585
Compare
Georacer
suggested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Has there been any kind of testing?
|
re-implement send_status_report in terms of get_variances and support EKF failsafe with ExternalAHRS
tridge
force-pushed
the
pr-external-AHRS-variances
branch
from
October 19, 2024 23:39
8cdf585
to
fa6c811
Compare
@Georacer I had stuffed up the scaling! Fixed up now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies backends, allows GCS to see variances in EKF message, and allows for copter EKF failsafe to work
broken out of #24747