Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heli autorotation restructure mode and improve speed controller #28209

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MattKear
Copy link
Contributor

@MattKear MattKear commented Sep 24, 2024

This PR is the next step in bringing on the autorotation flight mode. It builds on the work done in #27786 and is dependant upon it. Hence, the diff looks very large at the moment.

The following changes have been made:

  • A much needed re-structure to move more of the code out of the mode and down into the autorotation library
  • Add pre-arm checks specific to the autorotation mode
  • Improvement of the speed controller by moving to a full PID instead of just P and FF. Also, the accel limiting that I had previously implemented was a bit weird, so I have improved that.
  • Move from a stabilise style control where pilot has to do both yaw and roll control, to a lateral acceleration controller, whereby pilot requests a lateral accel component and the controller figures out the roll angle and yaw rate needed to do a co-ordinated turn.

Testing has been in Real flight only.

The majority of this PR is still behind the SITL only wall.

Special attention should be paid to the changes in AP_MotorsHeli_Single, _Dual & _Quad whereby I have slightly modified the way we detect the collective is on land col min. A modification to the autorotation auto test highlighted that this flag was not tripping when collective was being constrained to land col min. This bit is not SITL only

@MattKear MattKear added the WIP label Sep 24, 2024
@MattKear MattKear force-pushed the pr_heli_autorotation_restructure_mode branch 3 times, most recently from 70cff60 to 05b1cb1 Compare October 12, 2024 15:09
@MattKear MattKear changed the title Heli autorotation restructure mode and use position controller Heli autorotation restructure mode and improve speed controller Oct 12, 2024
@MattKear MattKear removed the WIP label Oct 12, 2024
@MattKear MattKear force-pushed the pr_heli_autorotation_restructure_mode branch from 05b1cb1 to 8ef67b4 Compare October 26, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant