Don't convert SUIT_digest bytes to hex representation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bremoran Ping! :) |
|
I think this issue should also be fixed in #43. Would you like to verify? |
The offending line still results in a CBOR text string (and not in a CBOR byte string) if I'm correct. I'll verify tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the COSE signature payload. The digest-bytes of the SUIT_digest object should be a bstr with the raw digest as content. In current master the digest-bytes is a hex representation of the digest which results in 1. a twice as long bstr (64 bytes instead of 32 bytes for sha256) and 2. incorrect digest verification on the receiver side.