Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less decimals for bbox info on project view page #4032

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Dec 18, 2023

Round value for project bounds in the project view page.

I also use a css transition instead of jquery slide
image

Ticket : #3558

Funded by 3Liz

@github-actions github-actions bot added this to the 3.8.0 milestone Dec 18, 2023
@gioman
Copy link
Contributor

gioman commented Dec 19, 2023

Fixes #3558

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a UX point of view, good.

Do you want to backport ?

@nworr
Copy link
Contributor Author

nworr commented Dec 20, 2023

only 3.7 ?

@nworr
Copy link
Contributor Author

nworr commented Dec 20, 2023

precision : it doesn't round values in the information panel

@gioman
Copy link
Contributor

gioman commented Jan 2, 2024

precision : it doesn't round values in the information panel

@nworr it would be highly appreciated if it would include also the info panel.

Also seems to me that

https://github.com/3liz/lizmap-web-client/pull/4032/files#diff-2c0e8b758097ca053a90b477e70751986f294f1d80fd8b85e0096e46dd21b4b0R38

just takes the first two decimal places from the bbox values, I think it would be better to round the values instead, and add some logic because for gepographical CRSs 2 decimal places is hardly enough to describe with precision an extent that has values in degrees (while is ok for projected CRSs).

@nworr nworr changed the title Less decimals for bbox info on project view page draft : Less decimals for bbox info on project view page Jan 5, 2024
@nworr nworr changed the title draft : Less decimals for bbox info on project view page Less decimals for bbox info on project view page Jan 5, 2024
@nworr nworr marked this pull request as draft January 5, 2024 13:43
@@ -35,7 +35,7 @@ public function __construct($id, $title, $abstract = '', $keywordList = '', $pro
$this->abstract = $abstract;
$this->keywordList = $keywordList;
$this->proj = $proj;
$this->bbox = $bbox;
$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox);
$this->bbox = preg_replace('/([0-9]+\.[0-9]{6})[0-9]+/', '$1', $bbox);

Can you provide 6 decimals ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I get the code at all... From a UX it would be nice to show 2 decimal places (rounded) for projected CRS, 6 I guess would be ok for geographical ones (degrees). Six decimals for CRSs in meters or feet do not give a good UX.

@Gustry
Copy link
Member

Gustry commented Apr 15, 2024

It's just my opinion, but these kind of information about extent, is not really human readible, and doesn't need to be displayed on the main landing page of Lizmap Web Client (which is the "page vitrine" of the LWC project, to give a first preview of the project).

If a GIS user wants to have it's extent, IMHO he should open the project and go in the information tab. It's really targeting precise GIS technicians be able to ready text representing coordinates.

I really like the work from @Jersig on his instance to make something "neat" and "slick" about the landing page of LWC : https://mapeo.calvados.fr/carto/index.php hiding quite a few complex information for most users.

Just my opinion (I got inspired from Spotify or Netflix apps, where just title, description and thumbnail are displayed nicely). All "secondary information" are coming in the second step (actors, producters,number of episodes). Sorry for the comparaison :)

@nworr nworr modified the milestones: 3.8.0, 3.9 May 13, 2024
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jun 24, 2024
Copy link

github-actions bot commented Jul 1, 2024

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 1, 2024
Copy link

github-actions bot commented Jul 8, 2024

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added the stale This ticket might be closed soon label Jul 8, 2024
@gioman
Copy link
Contributor

gioman commented Jul 8, 2024

Not stale, actually a very welcome UX improvement (this would also need to be applied to the BBOX values as shown in the project infos after having opened the map, not only in the LMWC landing page).

@3liz-bot 3liz-bot removed the stale This ticket might be closed soon label Jul 8, 2024
@nworr
Copy link
Contributor Author

nworr commented Jul 8, 2024

This PR is now outdated, and have conflicts with master branch (and release_3_8 for sure).
The logic of simple rounding value is quite weak, as you noticed.
It need to use a smarter way to round value depending on projection unit, and it will be performed in another way (dedicated class/ method, maybe only on browser side).
Thus IMHO, another PR will be more relevant, and the original ticket keep track of this one which is usefull (even closed)

@Gustry
Copy link
Member

Gustry commented Jul 8, 2024

IMHO, displaying coordinates in a web interface is very GIS technicians oriented. I don't think that reading coordinates is done by a lot of humans, in a web interface :)

I really would like to see something more user-friendly, similar to what Calvados has done for instance, slick, very oriented for non-GIS technicians :

Peek 2024-07-08 17-47

@gioman
Copy link
Contributor

gioman commented Jul 9, 2024

@Gustry what I can say... I agree! but since that bbox values are shown since... always, I assumed that you wanted to keep them. If in reality you want to get rid of them, please go on!

@Gustry
Copy link
Member

Gustry commented Jul 10, 2024

Ah great, as my previous comment just above last April didn't get attraction, and as you commented "not stale", I thought you were interested into this PR :D
I don't need these coordinates either ;-)

It looks IMHO easier to close this PR if we agree and to create a new one removing codes ;-)

This interface needs a more modern UI, which started in LWC 3.7 with this new theme. Hands are welcome, if you have some design, CSS skills etc.

@nworr, it's up to you :)

Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 10, 2024
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 17, 2024
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 24, 2024
Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 31, 2024
@Gustry Gustry modified the milestones: 3.9.0, 3.10.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants