-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less decimals for bbox info on project view page #4032
base: master
Are you sure you want to change the base?
Conversation
Fixes #3558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UX point of view, good.
Do you want to backport ?
only 3.7 ? |
precision : it doesn't round values in the information panel |
@nworr it would be highly appreciated if it would include also the info panel. Also seems to me that just takes the first two decimal places from the bbox values, I think it would be better to round the values instead, and add some logic because for gepographical CRSs 2 decimal places is hardly enough to describe with precision an extent that has values in degrees (while is ok for projected CRSs). |
@@ -35,7 +35,7 @@ public function __construct($id, $title, $abstract = '', $keywordList = '', $pro | |||
$this->abstract = $abstract; | |||
$this->keywordList = $keywordList; | |||
$this->proj = $proj; | |||
$this->bbox = $bbox; | |||
$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox); | |
$this->bbox = preg_replace('/([0-9]+\.[0-9]{6})[0-9]+/', '$1', $bbox); |
Can you provide 6 decimals ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I get the code at all... From a UX it would be nice to show 2 decimal places (rounded) for projected CRS, 6 I guess would be ok for geographical ones (degrees). Six decimals for CRSs in meters or feet do not give a good UX.
It's just my opinion, but these kind of information about extent, is not really human readible, and doesn't need to be displayed on the main landing page of Lizmap Web Client (which is the "page vitrine" of the LWC project, to give a first preview of the project). If a GIS user wants to have it's extent, IMHO he should open the project and go in the information tab. It's really targeting precise GIS technicians be able to ready text representing coordinates. I really like the work from @Jersig on his instance to make something "neat" and "slick" about the landing page of LWC : https://mapeo.calvados.fr/carto/index.php hiding quite a few complex information for most users. Just my opinion (I got inspired from Spotify or Netflix apps, where just title, description and thumbnail are displayed nicely). All "secondary information" are coming in the second step (actors, producters,number of episodes). Sorry for the comparaison :) |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
Not stale, actually a very welcome UX improvement (this would also need to be applied to the BBOX values as shown in the project infos after having opened the map, not only in the LMWC landing page). |
This PR is now outdated, and have conflicts with master branch (and release_3_8 for sure). |
IMHO, displaying coordinates in a web interface is very GIS technicians oriented. I don't think that reading coordinates is done by a lot of humans, in a web interface :) I really would like to see something more user-friendly, similar to what Calvados has done for instance, slick, very oriented for non-GIS technicians : |
@Gustry what I can say... I agree! but since that bbox values are shown since... always, I assumed that you wanted to keep them. If in reality you want to get rid of them, please go on! |
Ah great, as my previous comment just above last April didn't get attraction, and as you commented "not stale", I thought you were interested into this PR :D It looks IMHO easier to close this PR if we agree and to create a new one removing codes ;-) This interface needs a more modern UI, which started in LWC 3.7 with this new theme. Hands are welcome, if you have some design, CSS skills etc. @nworr, it's up to you :) |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
Round value for project bounds in the project view page.
I also use a css transition instead of jquery slide
Ticket : #3558
Funded by 3Liz