Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use css transitions instead of js for project description #4055

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Jan 5, 2024

commit cherry-picked from #4032

see behavior in https://jsfiddle.net/nworr/xqet7ohm/24/

Funded by 3Liz

@github-actions github-actions bot added this to the 3.8.0 milestone Jan 5, 2024
@nworr nworr merged commit 1b302d4 into 3liz:master Jan 23, 2024
10 checks passed
@nworr nworr modified the milestones: 3.8.0, 3.7.3 Jan 23, 2024
@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Jan 24, 2024
@Gustry
Copy link
Member

Gustry commented Jan 24, 2024

@nworr I might get wrong, but this PR seems linked to new failing test on cypress

https://github.com/3liz/lizmap-web-client/actions/runs/7641473251 on this branch and now on master

  2 failing

  1) Projects homepage
       should display project metadata (cold cache):
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.liz-project-desc`, but never found it. Queried from element: <div.liz-project>
      at Context.eval (http://localhost:8130/__cypress/tests?p=cypress/integration/projects_homepage-ghaction.js:104:93)

  2) Projects homepage
       should display project metadata  (hot cache):
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.liz-project-desc`, but never found it. Queried from element: <div.liz-project>
      at Context.eval (http://localhost:8130/__cypress/tests?p=cypress/integration/projects_homepage-ghaction.js:129:93)

@nworr
Copy link
Contributor Author

nworr commented Jan 25, 2024

i agree, the PR change the liz-project-desc position in DOM, quick fix can be done, perhaps using playwright, i'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants