Google Search: Allow extracting items from SERP results #78
Conversation
| "enumMeta": { | ||
| # TODO: Add a test to make sure this is in sync with the enum class above. | ||
| # TODO: Try automating the generation of this metadata from the enum type above. | ||
| SerpItemType.serp: { |
There was a problem hiding this comment.
Hm, that's an interesting idea. I was thinking that the default here would be None, which means "don't go to the results, output the links".
There was a problem hiding this comment.
This made more sense to me when calling the field Item type, but we could call it something else, e.g. Extract from results. If you prefer the None approach, do you have some ideas in mind for the field name?
There was a problem hiding this comment.
I'm not too worried about the field name; "extract from results" makes sense, and even "item type" sound ok to me with None default. If you're looking for an alternative, something like "follow and extract"?
By the way, we should also add custom attributes extraction here :) It doesn't need to be in this PR, but we should eventually have it.
To do:
ForumThreadto https://github.com/zytedata/zyte-common-items