Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually add the article rules themselves. #12

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Actually add the article rules themselves. #12

merged 3 commits into from
Nov 5, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Nov 4, 2024

🤦‍♂️

@Gallaecio
Copy link

I thought it was on purpose, as a future thing to add 🤦

@Gallaecio
Copy link

Do we need tests that are counterparts to those that got renamed from main to product on the previous PR?

@wRAR
Copy link
Member Author

wRAR commented Nov 4, 2024

Surprisingly, there were no tests for queryRemoval/*.json so I didn't add them for queryRemoval/articles.json :) I think they will be useful though.

@wRAR wRAR marked this pull request as draft November 4, 2024 14:12
@wRAR wRAR marked this pull request as ready for review November 5, 2024 13:15
@wRAR wRAR merged commit 8b1fb3e into main Nov 5, 2024
10 checks passed
@wRAR wRAR deleted the article-rules-2 branch November 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants