improve declarations.Provides documentation
#274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct signature
|
As you mention that the signature is wrong, what prevents you from updating it? |
|
Jürgen Gmach wrote at 2023-8-23 23:14 -0700:
As you mention that the signature is wrong, what keeps you from updating it?
Respect for the original author: he might have had a reason for
"his" signature.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
declarations.Providesis given as*interfaces. This is wrong; it actually iscls, *interfaceswhere cls is the class of the instance for whichProvidesshould provide a declaration. This parameter is necessary to avoid the construction of inconsistent resolution orders.The PR does not change the code but improves the
Providesdocstring and especially documents the correct signature there.