feat(boards): allow use of blackpill_f401cc #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/boards/blackpill_f401cc.conf
Outdated
| CONFIG_UART_CONSOLE=n | ||
| CONFIG_UART_INTERRUPT_DRIVEN=n | ||
| CONFIG_ZMK_USB=y | ||
| CONFIG_ZMK_BLE=n |
There was a problem hiding this comment.
This is probably superfluous? If preset in the others I would suggest removing them.
There was a problem hiding this comment.
This is probably superfluous? If preset in the others I would suggest removing them.
You're right; CONFIG_ZMK_BLE=n isn't necessary on any of the BlackPill configurations.
|
|
||
| blackpill_i2c: &i2c1 {}; | ||
| blackpill_spi: &spi1 {}; | ||
| blackpill_serial: &usart1 {}; |
There was a problem hiding this comment.
Are these peripherals already set up properly in the base board definition I assume?
There was a problem hiding this comment.
Are these peripherals already set up properly in the base board definition I assume?
Yes.
lesshonor
force-pushed
the
boards/blackpill-f401cc
branch
from
e051df9
to
ba7b923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zephyr's
blackpill_f401ceandblackpill_f411ceboard definitions were enabled for use in ZMK in 70aa4fa. I can think of no good reason why all three should not be available options, particularly as a lot of clones tend to use F401CC.