-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards): Update for mikoto board definition #1946
base: main
Are you sure you want to change the base?
Conversation
a bunch of stuff came up, haven't had time to move this forward atm. though i will say that my changes work locally (ignoring any breaking changes). |
51ce987
to
ebf23fe
Compare
had some time to pick this up again; so what i've changed now is:
basically, now we should handle the new cases ( EDIT: I've split out the non-mikoto stuff into a new PR #2157, which should be merged first. I'll rebase this on that after. I've set up a test repo that builds both |
27ab8a7
to
56f8ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit efa9134 included these three files (build.sh, uf2s) by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, you're right. I'll clean this up after #2157 gets merged, thanks!
aight, #2157 got merged so i'll pick this up in a bit |
@zhiayang the display adapter overlay also needs to be copied to |
This PR updates the mikoto board definition to use Zephyr revisions, while adding support for new revisions (6.1+, 7.1+) that have incompatibilities/new hardware.
I only version mikoto with MAJOR.MINOR, so I've set the PATCH level to 0 for the zephyr overlay files. Unfortunately this breaks existing configs that use
mikoto_520
as the board name. Is that a major issue?Board/Shield Check-list
.zmk.yml
metadata file added.conf
file has optional extra features commented out