-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leeloo v2 and Leeloo-Micro v1 updates to support Zephyr 3.2 #1762
Leeloo v2 and Leeloo-Micro v1 updates to support Zephyr 3.2 #1762
Conversation
Can you please rebase to handle the conflicts? |
1d3fcf1
to
b964048
Compare
Hi @petejohanson! Thank you very much; I was able to rebase, yet, I found out that I didn't have pre-commit installed. I was able to install and run; everything seems to be okay now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One main thought on first view. Then I wondered whether we could do revisions for this rather than two separate shields. I know we discovered it after the nice!nano v2 came out, and I don't recall if any other "revision" items have been committed yet, so I wanted to revisit that now. I'm not sure if board revisions also work with shields, but they can be read about here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general, aside from the issues I noted.
Can you also update the year on copyright headers to 2023?
Co-authored-by: Cem Aksoylar <[email protected]>
…plit/zmk into leeloo_micro_v1_branch
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out