Break error into micro crate #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
NAck
I would like some actual advantages before we consider this...
as you said a "crate" is a stand-a-lone part so having lots of crates all depend on one error crate doesnt seem right to me. Having the errors of one crate in another crate doesnt seem right either. also I cant actually think of an application of a workspace-wide error. most likely if our codebase was as suggested int his PR, I would think its a good idea to open a PR which sorts the big heap of random error in this new crate into the crates it belongs in. therefore this seems like an anti-pattern to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An argument in favor: The codebase inside zingolib is shrinking.