Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer transaction id over txid #965

Closed
wants to merge 1 commit into from

Conversation

zancas
Copy link
Member

@zancas zancas commented Apr 19, 2024

No description provided.

@zancas zancas requested a review from AloeareV April 19, 2024 18:15
@fluidvanadium
Copy link
Contributor

in this case, i disagree because TxId is the LRZ type we rely on.

@zancas
Copy link
Member Author

zancas commented Apr 19, 2024

I see your point, but couldn't that actually be an argument in favor? The developer can read the foreign crate type in the signature.. now.. without further action it's disambiguated by the ident as "a transaction" as opposed to e.g. "a transmission". So our more-explicit naming convention produces an ident that helps to (locally) fix an ambiguity introduced by the slightly less careful name being used elsewhere?

@zancas zancas closed this Apr 22, 2024
@zancas zancas deleted the transaction_id_over_txid branch May 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants