Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry build rs #458

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Dry build rs #458

merged 6 commits into from
Sep 1, 2023

Conversation

zancas
Copy link
Member

@zancas zancas commented Sep 1, 2023

No description provided.

@zancas
Copy link
Member Author

zancas commented Sep 1, 2023

Hi @fluidvanadium can you review this code?

@juanky201271
Copy link
Contributor

juanky201271 commented Sep 1, 2023

fluidvanadium
fluidvanadium previously approved these changes Sep 1, 2023
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may be an organizational improvement

@zancas zancas dismissed fluidvanadium’s stale review September 1, 2023 16:50

The merge-base changed after approval.

@zancas
Copy link
Member Author

zancas commented Sep 1, 2023

@zancas did you this error: https://github.com/zingolabs/zingolib/actions/runs/6045572683/job/16405837116?pr=458#step:7:29

Yeah.. I think that this is because I forgot to commit the new crate.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (8e1fe3c) 60.18% compared to head (9723c59) 60.20%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #458      +/-   ##
==========================================
+ Coverage   60.18%   60.20%   +0.02%     
==========================================
  Files          33       33              
  Lines        5377     5375       -2     
==========================================
  Hits         3236     3236              
+ Misses       2141     2139       -2     
Files Changed Coverage Δ
zingolib/src/wallet/transactions.rs 64.15% <ø> (-0.12%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zancas zancas merged commit 073b8a9 into zingolabs:dev Sep 1, 2023
13 of 20 checks passed
@zancas zancas deleted the DRY_build_rs branch September 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants