-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spacers and Points in zingocli balance command #1464
base: dev
Are you sure you want to change the base?
Conversation
ce70576
to
4b64fb1
Compare
4b64fb1
to
4ef36b0
Compare
Is this moving us towards reproducing the vaporizing transaction bug? |
@@ -128,6 +128,63 @@ pub struct PoolBalances { | |||
/// TODO: Add Doc Comment Here! | |||
pub transparent_balance: Option<u64>, | |||
} | |||
fn format_option_zatoshis(ioz: &Option<u64>) -> String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what "ioz
" means.
It looks like this crate has been downloaded aroun 15_000_000 times: https://crates.io/crates/num-format Why don't we us it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use num-format.
I really like the idea of a more useful/readable zingocli interface. I don't like the idea of writing our own reimplementation of standard logic. Let's use the thing that's "off-the-shelf". |
the answer is: num-format doesnt specifically make use of the 10,000,000 mark for Satoshis |
Adding a decimal point allows easy estimation of zec per zatoshi.