Add Spacers and Points in zingocli balance command #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidvanadium
requested review from
zancas,
juanky201271,
AloeareV,
Oscar-Pepper and
idky137
fluidvanadium
force-pushed
the
zingocli_places
branch
2 times, most recently
from
ce70576
to
4b64fb1
Compare
fluidvanadium
force-pushed
the
zingocli_places
branch
from
4b64fb1
to
4ef36b0
Compare
|
Is this moving us towards reproducing the vaporizing transaction bug? |
zancas
reviewed
Oct 22, 2024
| @@ -128,6 +128,63 @@ pub struct PoolBalances { | |||
| /// TODO: Add Doc Comment Here! | |||
| pub transparent_balance: Option<u64>, | |||
| } | |||
| fn format_option_zatoshis(ioz: &Option<u64>) -> String { | |||
|
It looks like this crate has been downloaded aroun 15_000_000 times: https://crates.io/crates/num-format Why don't we us it? |
|
I really like the idea of a more useful/readable zingocli interface. I don't like the idea of writing our own reimplementation of standard logic. Let's use the thing that's "off-the-shelf". |
the answer is: num-format doesnt specifically make use of the 10,000,000 mark for Satoshis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a decimal point allows easy estimation of zec per zatoshi.