Zingo sync scan transaction #1331
Conversation
Oscar-Pepper
requested review from
zancas,
AloeareV,
fluidvanadium and
idky137
| ) | ||
| .unwrap(); | ||
| } | ||
|
|
There was a problem hiding this comment.
// TODO: scan transparent?
There was a problem hiding this comment.
indeed! i have added a TODO to my latest PR
| } | ||
|
|
||
| fn scan_notes<D, Op, N>( | ||
| wallet_notes: &mut Vec<N::WalletNote>, |
There was a problem hiding this comment.
why do we need to pass a mutable vector here? I see that the input is empty. instead of the extra parameter just initialize an empty vector in the function
There was a problem hiding this comment.
this way is the simplest and cleanest because the vec is initialised in the right scope. if the vec was created by the scan_notes fn then we would have to return it out of the if let block. this gets more complicated as there will also be outgoing notes and encoded memos that also need returning from the block
|
I pushed a resolution of merge conflicts with latest dev. |
ontop of #1328