-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zingo sync scan transaction #1331
base: dev
Are you sure you want to change the base?
Zingo sync scan transaction #1331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs a couple edits. i like how its moving.
) | ||
.unwrap(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: scan transparent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed! i have added a TODO to my latest PR
} | ||
|
||
fn scan_notes<D, Op, N>( | ||
wallet_notes: &mut Vec<N::WalletNote>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to pass a mutable vector here? I see that the input is empty. instead of the extra parameter just initialize an empty vector in the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this way is the simplest and cleanest because the vec is initialised in the right scope. if the vec was created by the scan_notes fn then we would have to return it out of the if let block. this gets more complicated as there will also be outgoing notes and encoded memos that also need returning from the block
I pushed a resolution of merge conflicts with latest dev. |
ontop of #1328