[Backport v3.7-branch] drivers: dai: sai: don't crash on underrun/overrun #77651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TX/RX FIFO underrun shouldn't crash the RTOS when it occurs. Also, since this can also happen under "normal" conditions (i.e: DMA doesn't copy data fast enough from/to SAI's FIFOs) the software should be able to recover from it. As such: 1) Remove `z_irq_spurious()` call. 2) Clear error flag 3) De-escalate error message to warning message Signed-off-by: Laurentiu Mihalcea <[email protected]> (cherry picked from commit e224a41)
zephyrbot
requested review from
kv2019i,
marcinszkudlinski and
abonislawski
as code owners
zephyrbot
requested review from
dbaluta,
iuliana-prodan,
juimonen,
LaurentiuM1234 and
lgirdwood
iuliana-prodan
approved these changes
Aug 27, 2024
dbaluta
approved these changes
Aug 27, 2024
|
@nashif is it possible to re-run the CI jobs on this? looks like a seemingly unrelated issue with the twister tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e224a41 from #77236.
Fixes #77633