Skip to content

Commit

Permalink
Bluetooth: Controller: Remove incorrect check of RFU bit
Browse files Browse the repository at this point in the history
RFU bits has to be ignored according to the spec; In addition,
some MediaTek devices seems to have it set (by mistake I assume),
so having the check means we cannot sync to these devices

Signed-off-by: Troels Nilsson <[email protected]>
  • Loading branch information
Tronil authored and dleach02 committed Oct 18, 2024
1 parent b590c0b commit 6f64f77
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions subsys/bluetooth/controller/ll_sw/ull_scan_aux.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,12 @@ void ull_scan_aux_setup(memq_link_t *link, struct node_rx_pdu *rx)

h = (void *)p->ext_hdr_adv_data;

/* Regard PDU as invalid if a RFU field is set, we do not know the
* size of this future field, hence will cause incorrect calculation of
* offset to ACAD field.
/* Note: The extended header contains a RFU flag that could potentially cause incorrect
* calculation of offset to ACAD field if it gets used to add a new header field; However,
* from discussion in BT errata ES-8080 it seems clear that BT SIG is aware that the RFU
* bit can not be used to add a new field since existing implementations will not be able
* to calculate the start of ACAD in that case
*/
if (h->rfu) {
goto ull_scan_aux_rx_flush;
}

ptr = h->data;

Expand Down

0 comments on commit 6f64f77

Please sign in to comment.