Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add usb folder for gd32f4xx #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add usb folder for gd32f4xx #33

wants to merge 1 commit into from

Conversation

lmikl
Copy link

@lmikl lmikl commented Oct 5, 2023

add usb folder for gigadevice GD32f4xx

@nandojve
Copy link
Member

Read the README about how to submit code.
This part should go first than the driver and it is necessary a link between the two PR.

gmarull
gmarull requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be adding a new usb stack? cc: @jfischer-no

@jfischer-no
Copy link

jfischer-no commented Nov 28, 2023 •
edited
Loading

this seems to be adding a new usb stack? cc: @jfischer-no

Yes, looks like there is a lot of garbage. btw USB controller looks like DWC2 IP and we have a native driver for it.

edit: I found counterpart PR zephyrproject-rtos/zephyr#63585, so both make no sense to me, native drivers already exist in the project.

@jfischer-no jfischer-no mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarull gmarull gmarull requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmikl @nandojve @jfischer-no @gmarull