Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetime columns timezone conversion fix #1779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpmarques
Copy link

@lpmarques lpmarques commented Nov 27, 2021

As reported here, although mysql datetime values are not stored with any timezone information, Maxwell bootstrap utility adds it to them based on database's timezone, and then proceeds to convert them to client server timezone. Such unexpected behavior does not occur in the CDC process.

This is an attempt on avoiding the problem by treating datetime values as simple strings.

@osheroff
Copy link
Collaborator

kinda scary and deep. might work, but would need far more tests around various behaviors.

@lpmarques
Copy link
Author

@osheroff, as mentioned in the issue, I've run some tests and confirmed the fix works for datetimes of any precision, making the bootstrapping process coherent with CDC's behavior of replicating datetime values as stored.

What further tests would you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants