Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement and many fixes/improvement to the code #22

Merged
merged 11 commits into from
May 3, 2017

Conversation

ubellavance
Copy link
Contributor

No description provided.

@ubellavance ubellavance changed the title Documentation improvement + variable declaration fix Documentation improvement + variable declaration fix + added a require on the service for the bootstrap Apr 22, 2017
@ubellavance ubellavance changed the title Documentation improvement + variable declaration fix + added a require on the service for the bootstrap Documentation improvement and many fixes/improvement to the code Apr 24, 2017
Copy link
Contributor Author

@ubellavance ubellavance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to set my username, so it's root while it should have been ubellavance. I don't know how to fix that.

@ubellavance
Copy link
Contributor Author

This PR should be quite safe to merge at this point. However, it forces the usage of the api_key_secret of 64 characters and an admin_api_key_name of 5-20 characters.

I'll keep working on the module and make more commits. I've tested it successfully with RHEL7, puppet 3.6.2 (from epel) and puppetlabs-stdlib v4.3.2. I'm also testing it on Ubuntu 16.04 (LTS). It works on Ubuntu 16.04, but there is a bug (#23). I haven't found a solution yet, I have to do more troubleshooting.

@slaff slaff requested a review from davidl-zend April 25, 2017 12:09
Many improvements, updates, fixes. Updated the supported components section, re-organized the description of what the module does. Other fixes.
Fixed ZS server versions list
…hen remove the installation of the lsb package requirement.
@mkherlakian mkherlakian merged commit 407b423 into zend-patterns:master May 3, 2017
@ubellavance ubellavance mentioned this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants