Set up REL templates #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtk can't always reliably identify REL sections in its initial analysis. This is a manual fix - the list of RELs to fix was found by looking at supposed .rodata splits that contained an fBase vtable, since vtables should be in .data. This fix is required for scripted creation of REL actors based on rel .data
robojumper
force-pushed
the
rel_automation
branch
from
80020b7
to
e9fa1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up headers (with state managers and states) and a corresponding C++ file with actor profile and state functions, and automatically labels all the boilerplate functions in symbols.txt for ~600 RELs. The info was mined from dtk's split asm files using a script I've included in this PR for posterity, though it's far less useful now.
This is a pretty significant increase to the matched-but-unlinked percentage in our RELs and should hopefully make it easier to work on RELs.