Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move baserom segments to extracted/ #1916

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Mar 4, 2024

Sorry for breaking ZAPD CI yet again

.gitignore Outdated Show resolved Hide resolved
@fig02
Copy link
Collaborator

fig02 commented Mar 4, 2024

I was wrongly under the impression that this change would allow use to remove the baseroms/ folder entirely, but I guess that doesn't make sense. cause we still need a place to put it for the extraction step to use.

Is extracted/{VERSION}/segments clear enough? do we want to indicate that they are baserom/binary somehow, or does the term "segments" already convey that well enough?

@cadmic
Copy link
Contributor Author

cadmic commented Mar 4, 2024

Oh yeah, it's actually called extracted/$VERSION/baserom in the latest version in #1904 (similar to how the .o versions are in build/$VERSION/baserom). I'll make that change

@Dragorn421
Copy link
Collaborator

extracted/ conveys that it's from the baserom

@Dragorn421
Copy link
Collaborator

Oh yeah, it's actually called extracted/$VERSION/baserom in the latest version in #1904 (similar to how the .o versions are in build/$VERSION/baserom). I'll make that change

Yeah may as well

@fig02
Copy link
Collaborator

fig02 commented Mar 4, 2024

it sounds like itll be more clear for the user, but it will be a bit silly that baserom/ only has 1 item which is segments/, right?

@cadmic
Copy link
Contributor Author

cadmic commented Mar 4, 2024

I think the idea is that there will be no segments path component, it will be e.g. extracted/gc-eu-mq-dbg/baserom/nes_message_data_static (similar to build/gc-eu-mq-dbg/baserom/nes_message_data_static.o)

@fig02 fig02 merged commit bf37ad1 into zeldaret:main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants