Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadFragment 2 OK #2

Merged
merged 17 commits into from
Jul 29, 2023
Merged

LoadFragment 2 OK #2

merged 17 commits into from
Jul 29, 2023

Conversation

hensldm
Copy link
Contributor

@hensldm hensldm commented Mar 29, 2023

Matches and docs the functions related to overlay relocation. Decided to name the file based off MM, but the functions off OoT. Open to suggestions as always :).

@AngheloAlf
Copy link
Contributor

Waiting for #3

@hensldm
Copy link
Contributor Author

hensldm commented Apr 4, 2023

Small note, it looked like the original place I had gOverlayLogSeverity was actually a collision with gfxprint_font. It seemed more likely to actually be above the gfxprint data, which means it had to be its own file like in OoT.

@AngheloAlf AngheloAlf removed the held label Apr 4, 2023
@AngheloAlf
Copy link
Contributor

No longer waiting for #3

Copy link
Contributor

@EllipticEllipsis EllipticEllipsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this uses -O2 instead of -O2 -g3 like most files it ought to have its own flags specified.

include/load.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only going to be for loadfragment2 it seems better to name it after the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadfragment2 isn't the only file that will include this. Any folder that uses Overlay_Relocate will as well. That I do see a point in naming it something like loadfragment.h so will do that (I don't really want to add the 2).

@hensldm
Copy link
Contributor Author

hensldm commented May 9, 2023

Since this uses -O2 instead of -O2 -g3 like most files it ought to have its own flags specified.

Do we want to go the directory route? If so should we go boot_O2 and boot_O2_g3, or just nest O2 and O2_g3 in the boot folder?

@AngheloAlf
Copy link
Contributor

Since this uses -O2 instead of -O2 -g3 like most files it ought to have its own flags specified.

Do we want to go the directory route? If so should we go boot_O2 and boot_O2_g3, or just nest O2 and O2_g3 in the boot folder?

I think I prefer if we went with the directory route. I'm not sure what would be the best way of sorting them, but I kinda like the idea of nesting boot_O2 and boot_O2_g3 inside of boot

@hensldm
Copy link
Contributor Author

hensldm commented Jul 23, 2023

Since this uses -O2 instead of -O2 -g3 like most files it ought to have its own flags specified.

Do we want to go the directory route? If so should we go boot_O2 and boot_O2_g3, or just nest O2 and O2_g3 in the boot folder?

I think I prefer if we went with the directory route. I'm not sure what would be the best way of sorting them, but I kinda like the idea of nesting boot_O2 and boot_O2_g3 inside of boot

I went with just an O2 folder inside of boot. Does that seem fine? Note this will also affect #22

@AngheloAlf AngheloAlf merged commit ea9f4c6 into zeldaret:main Jul 29, 2023
@hensldm hensldm deleted the load branch July 31, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants