Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos extension #1381

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Add typos extension #1381

merged 3 commits into from
Sep 9, 2024

Conversation

BaptisteRoseau
Copy link
Contributor

Add support for the Typos Language Server.

Typos is a spell checker, this extension will help having a bit of spell checking available while waiting for zed-industries/zed#5305

Copy link

cla-bot bot commented Sep 8, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @BaptisteRoseau on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@BaptisteRoseau
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Sep 8, 2024

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Sep 8, 2024
@maxdeviant maxdeviant changed the title ext: Add typos v0.0.1 Add typos v0.0.1 Sep 9, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant changed the title Add typos v0.0.1 Add typos extension Sep 9, 2024
@maxdeviant maxdeviant merged commit 672d925 into zed-industries:main Sep 9, 2024
2 checks passed
@peteruithoven
Copy link

Would be good to add some Zed specific docs to Typos repo?
https://github.com/tekumara/typos-lsp?tab=readme-ov-file#install

I'm mostly curious how to configure it using Zed's settings.
https://github.com/tekumara/typos-lsp/blob/main/docs/vscode-settings.md

@BaptisteRoseau
Copy link
Contributor Author

@peteruithoven I'll look into it. For now I made a very simple PR just to add the LSP to make it available in the markeplace. I'll add configuration and documentation in the next few days 👍.

@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Sep 10, 2024

Super happy to have this in! I notice that typos is very-low positive, and so it doesn't catch as much as I would expect, but anything is an improvement over what we currently have. Happy to see squiggles in my Markdown! Thanks @BaptisteRoseau!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants