Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups, refactoring, and placeholder for TEX addresses #1423

Merged
merged 16 commits into from
Jun 18, 2024
Merged

Cleanups, refactoring, and placeholder for TEX addresses #1423

merged 16 commits into from
Jun 18, 2024
+484 −341

Commits on Jun 18, 2024

  1. Cosmetic fixes to changelog. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1d9fede View commit details
    Browse the repository at this point in the history

  2. Allow ChangeValue::output_pool to reference the transparent pool by 

    changing its type from `ShieldedProtocol` to `PoolType`.

Also fix compilation errors when the "orchard" feature is used without
the "transparent-inputs" feature.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3582f84 View commit details
    Browse the repository at this point in the history

  3. The return type of ChangeValue::new is now optional; it returns None 

    if a memo is given for the transparent pool. Use `ChangeValue::shielded`
to avoid this error case when creating a `ChangeValue` known to be for a
shielded pool.

Co-authored-by: Jack Grigg <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira @str4d
    daira and str4d committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c3e532f View commit details
    Browse the repository at this point in the history

  4. Prefer the PoolType::{SAPLING, ORCHARD, TRANSPARENT} constants to 

    `PoolType::{Shielded(_), Transparent}`.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6c90219 View commit details
    Browse the repository at this point in the history

  5. Add zcash_keys::Address::Tex. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2337f79 View commit details
    Browse the repository at this point in the history

  6. Add zcash_client_backend::fees::{sapling,orchard}::EmptyBundleView. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cefbaf5 View commit details
    Browse the repository at this point in the history

  7. Add OutPoint::fake() helper. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6d35583 View commit details
    Browse the repository at this point in the history

  8. Refactor FeeRule::fee_required to take the sizes of transparent 

    inputs and outputs.

Co-authored-by: Kris Nuttycombe <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira @nuttycom
    daira and nuttycom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    17af8e3 View commit details
    Browse the repository at this point in the history

  9. Add zcash_encoding::{CompactSize, Vector}::serialized_size and 

    `zcash_primitives::legacy::Script::serialized_size`. Use the latter in
`zcash_primitives::transaction::fees::transparent::OutputView::serialized_size`.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9881861 View commit details
    Browse the repository at this point in the history

  10. Address a review comment concerning Vector::serialized_size. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6f4a3b1 View commit details
    Browse the repository at this point in the history

  11. Use a simpler way of ascribing a type to an empty slice. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c9c7fa3 View commit details
    Browse the repository at this point in the history

  12. Miscellaneous documentation improvements. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9881e81 View commit details
    Browse the repository at this point in the history

  13. "child index" -> "address index" where applicable. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    41c30ef View commit details
    Browse the repository at this point in the history

  14. Fix a typo in an error message. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    dcf0187 View commit details
    Browse the repository at this point in the history

  15. Define an error type alias for brevity. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4f935a7 View commit details
    Browse the repository at this point in the history

  16. Refactoring of change calculation. 

    Signed-off-by: Daira-Emma Hopwood <[email protected]>
    @daira
    daira committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0b7f60d View commit details
    Browse the repository at this point in the history