-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups, refactoring, and placeholder for TEX addresses #1423
Commits on Jun 18, 2024
-
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d9fede - Browse repository at this point
Copy the full SHA 1d9fedeView commit details -
Allow
ChangeValue::output_pool
to reference the transparent pool bychanging its type from `ShieldedProtocol` to `PoolType`. Also fix compilation errors when the "orchard" feature is used without the "transparent-inputs" feature. Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3582f84 - Browse repository at this point
Copy the full SHA 3582f84View commit details -
The return type of
ChangeValue::new
is now optional; it returnsNone
if a memo is given for the transparent pool. Use `ChangeValue::shielded` to avoid this error case when creating a `ChangeValue` known to be for a shielded pool. Co-authored-by: Jack Grigg <[email protected]> Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3e532f - Browse repository at this point
Copy the full SHA c3e532fView commit details -
Prefer the
PoolType::{SAPLING, ORCHARD, TRANSPARENT}
constants to`PoolType::{Shielded(_), Transparent}`. Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c90219 - Browse repository at this point
Copy the full SHA 6c90219View commit details -
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2337f79 - Browse repository at this point
Copy the full SHA 2337f79View commit details -
Add
zcash_client_backend::fees::{sapling,orchard}::EmptyBundleView
.Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cefbaf5 - Browse repository at this point
Copy the full SHA cefbaf5View commit details -
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d35583 - Browse repository at this point
Copy the full SHA 6d35583View commit details -
Refactor
FeeRule::fee_required
to take the sizes of transparentinputs and outputs. Co-authored-by: Kris Nuttycombe <[email protected]> Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17af8e3 - Browse repository at this point
Copy the full SHA 17af8e3View commit details -
Add
zcash_encoding::{CompactSize, Vector}::serialized_size
and`zcash_primitives::legacy::Script::serialized_size`. Use the latter in `zcash_primitives::transaction::fees::transparent::OutputView::serialized_size`. Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9881861 - Browse repository at this point
Copy the full SHA 9881861View commit details -
Address a review comment concerning
Vector::serialized_size
.Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f4a3b1 - Browse repository at this point
Copy the full SHA 6f4a3b1View commit details -
Use a simpler way of ascribing a type to an empty slice.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9c7fa3 - Browse repository at this point
Copy the full SHA c9c7fa3View commit details -
Miscellaneous documentation improvements.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9881e81 - Browse repository at this point
Copy the full SHA 9881e81View commit details -
"child index" -> "address index" where applicable.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 41c30ef - Browse repository at this point
Copy the full SHA 41c30efView commit details -
Fix a typo in an error message.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dcf0187 - Browse repository at this point
Copy the full SHA dcf0187View commit details -
Define an error type alias for brevity.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4f935a7 - Browse repository at this point
Copy the full SHA 4f935a7View commit details -
Refactoring of change calculation.
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b7f60d - Browse repository at this point
Copy the full SHA 0b7f60dView commit details